$http service in Factory returns undefined in AngularJS

Question

I am new in angularJS and try to make a CRUD operation to clear my concept. I try to use angular factory but I google a lot and unable to find any solution on below concept. I just want to use my factory in controller which is not working for me.

Factory :

(function () {
'use strict';

 angular
.module('app', [])
.factory("crudFactory", function (path, myObj) {
     return {
         AddObject: function (path)
         {
             $http({
                 method: "POST",
                 url: path,
                 params: { myObj : myObj }
             }).then(function mySuccess(response) {
                 return response.data;
             }, function myError(response) {
                 return "Error Found :" + response.statusText;
             });
         },
         first: function () {
             return "";//
         }
     };
});
})();

I want to use this factory in controller but its not working.

Controller :

(function () {
'use strict';
debugger;
  angular
 .module('app')
 .controller('BusinessProfileCtrl', BusinessProfileCtrl);

function BusinessProfileCtrl($scope, crudFactory) {
    debugger;
    var vm = this; //vm = view model
    function Save() {
        debugger;
        var businessObj = {
            Id:vm.Id,
            Name: vm.Name,
        };
        var abc = crudFactory.AddObject("http://localhost:63358/BusinessUnit/Post", businessObj);
    }
    vm.Save = Save;
}
 })();

Hope will get any help. Thanks in advance.

Define "not working". What are you doing, what do you expect to happen, what happens instead? What do you expect the variable abc to contain, since AddObject doesn't return anything? — JB Nizet
– JB Nizet, Commented Feb 24, 2017 at 18:04
The $http POST method should use the data property for data, not params. — georgeawg
– georgeawg, Commented Feb 25, 2017 at 3:02

Sachila Ranawaka · Accepted Answer · 2017-02-24 18:14:26Z

1

in factory just return the http promise and from the controller catch that promise.

modify the factory like this;

.factory("crudFactory", function() {
    return {
        AddObject: function(path,myObj) {
            return $http({
                method: "POST",
                url: path,
                params: {
                    myObj: myObj
                }
            })
        },
        first: function() {
            return ""; //
        }
    };
});

in the controller catch the promise like this

var abc;
crudFactory.AddObject("http://localhost:63358/BusinessUnit/Post", businessObj).then(function mySuccess(response) {
    abc = response.data;
}, function myError(response) {
    abc = "Error Found :" + response.statusText;
});

edited Feb 24, 2017 at 18:14

answered Feb 24, 2017 at 18:05

Sachila Ranawaka

41.6k8 gold badges62 silver badges87 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user7364287 Over a year ago

bro "function BusinessProfileCtrl($scope, crudFactory) {}" is this syntax okay?

Sachila Ranawaka Over a year ago

yeah its right although factory("crudFactory", function (path, myObj) { this is wrong. parameters should be removed. just updated the answer

Collectives™ on Stack Overflow

$http service in Factory returns undefined in AngularJS

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related