Node JS EJS get URL parameters

Question

I'm trying to read URL parameters in an EJS template, however everything I try or read from google isn't working. Here's the relevant part of my app.js file:

app.post('/account/logintoaccount', function(req, res) {
    var email = req.body.email;
    if(email === '') {
        res.redirect('https://myurl.com/account/login?e=bademail');
        return;
    }
    var password = req.body.password;
    if(password === '') {
        res.redirect('https://myurl.com/account/login?e=badpassword');
        return;
    }
    res.redirect('https://myurl.com/?email=' + email + '&pw=' + password);
});

And here's where I'm trying to display the variable in my EJS file:

<div id="title-text">
    <% if(!req.query.e) { %>
        <p>Log into your account:</p>
    <% } else if(req.query.e === "badpass") { %>
        <div class="alert alert-danger"><strong>Error</strong> incorrect password</div>
    <% } else if(req.query.e === "bademail") { %>
        <div class="alert alert-danger"><strong>Error</strong> unknown email address</div>
    <% } %>
</div>

If I remove this part of my EJS file my redirects work fine. The URL has the parameters in it and all is good. However whenever I try and use my URL parameters in any way shape or form in my EJS file it breaks and gives me an "X is undefined error". I've tried using 'e', 'req.query.e', 'this.e', 'this.req.query.e' and anything else that google results have suggested I do.

My end goal is to be able to read the URL parameters in https://myurl.com/account/login?e=somethinghere

Then check what 'e' holds. I've spent the last 30+ minutes reading over google results however I believe they're either outdated or I'm just doing them wrong. Can anyone help please? Thank you for your time

You need to show your GET /login handler. You are probably not passing the request object to your view. — Mikey
– Mikey, Commented Mar 20, 2017 at 0:58
@Mikey app.get('/account/:action', function(req, res) { res.render('account/' + req.params.action, { session: req.session }); }); This? If so what would I add to fix this? Thanks — Alexzander Flores
– Alexzander Flores, Commented Mar 20, 2017 at 1:02

Mikey · Accepted Answer · 2017-03-20 01:41:55Z

1

Just pass the request into your view

app.get('/account/:action', function(req, res) { 
   res.render('account/' + req.params.action, { 
      session: req.session,
      req: req
   });
});

answered Mar 20, 2017 at 1:41

Mikey

6,7564 gold badges25 silver badges49 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Mikey Over a year ago

Word of advice, it's better to store your errors in the session instead. Also, it's never a good idea to put a password in the URL.

j10 Over a year ago

@AlexzanderFlores : did you redirect or render . While using redirect how can we extract the query values in the ejs template

Collectives™ on Stack Overflow

Node JS EJS get URL parameters

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related