How can I insert and save data into database using Visual Studio and C#?

Question

public string ss = "Data Source=D\\SQLEXPRESS;Initial Catalog=gym;Integrated Security=True";

private void comboBox2_SelectedIndexChanged(object sender, EventArgs e)
{
    string q2 = "insert into gym.dbo.customer (name, weight, height, add_class, gender, fees) values ('" + this.textBox1.Text + "','" + this.textBox2.Text + "','" + this.textBox3.Text + "','" + this.comboBox1.Text + "','" + this.comboBox2.Text + "','" + this.comboBox3.Text + " ') ;";

    SqlConnection con = new SqlConnection(ss);
    SqlCommand cmd = new SqlCommand(q2, con);
    SqlDataReader read;

    try
    {
        con.Open();
        read = cmd.ExecuteReader();
        MessageBox.Show("Welcome to our gym");

        while (read.Read()) { };
    }
    catch (Exception ex)
    {
        MessageBox.Show(ex.Message);
    }
}

How can I insert and save data into the database using Visual Studio and C#?

This code throws an error. Anyone please give the suggestion to me to solve the error.

image description

What error? Also there's some very bad practice going on there - have a read up on SQL Injection. — C. Knight
– C. Knight, Commented Apr 17, 2017 at 10:30
invalid object name gym.dbo.customer it gives me this error .. no i haven't what is SQL injection?? @C.Knight — DaLîa MaHmôud
– DaLîa MaHmôud, Commented Apr 17, 2017 at 10:34
You probably just want dbo.customer, not gym.dbo.customer. — Crowcoder
– Crowcoder, Commented Apr 17, 2017 at 10:36
SQL Injection is a form of attack that (in your case) would allow the user to do whatever they want to your database (upto and including deleting it entirely) simply by choosing what they enter in your textboxes approriately — C. Knight
– C. Knight, Commented Apr 17, 2017 at 10:37

anis programmer · Accepted Answer · 2017-04-17 10:44:41Z

At first make sure your the data type of different column of customer table. Then make sure what type of data you have to save for combobox.

you have to get the selected value from your Combobox. combobox1,combobox2,combobox3 retuns only the class name

 System.Windows.Forms.ComboBox

Besides others, it is recommended to use parameter .. like this: You can follow this example

private void button1_Click(object sender, EventArgs e)
{
    using(SqlConnection con = new SqlConnection(@"Data Source=(LocalDB)\v11.0;AttachDbFilename=c:\users\abdul samad\documents\visual studio 2013\Projects\newpro\newpro\Database1.mdf;Integrated Security=True"))
    {
        try
        {

            using (var cmd = new SqlCommand("INSERT INTO registor (Name, FullName, Password, Email, Gander) VALUES (@Name,@Fullname,@Password,@Email, @Gander)"))
            {

                cmd.Connection = con;   
                cmd.Parameters.Add("@Name", txtfname.Text);
                cmd.Parameters.Add("@Fullname", txtfname.Text);
                cmd.Parameters.Add("@Password", txtpass.Text);
                cmd.Parameters.Add("@Email", txtemail.Text);
                cmd.Parameters.Add("@Gander", comboBox1.GetItemText(comboBox1.SelectedItem));

                con.Open()
                if(cmd.ExecuteNonQuery() > 0) 
                {
                   MessageBox.Show("Record inserted"); 
                }
                else
                {
                   MessageBox.Show("Record failed");
                }
            }
        }
        catch (Exception e)
        {
            MessageBox.Show("Error during insert: " + e.Message);
        }
    }
}

satnhak · Accepted Answer · 2017-04-17 10:46:25Z

0

The comments are getting a bit busy, so this is the sort of thing you need to do (including parameterising the query):

Specifically, you don't need a reader for an insert statement as it doesn't return a result set.

private void comboBox2_SelectedIndexChanged(object sender, EventArgs e)
{
    var sql = "insert into dbo.customer ...";
    using (var con = new SqlConnection(ss))
    {

        var cmd = new SqlCommand(sql , con);
        con.Open();
        cmd.ExecuteScalar();
        MessageBox.Show("Welcome to our gym");
    }
}

answered Apr 17, 2017 at 10:46

satnhak

9,9707 gold badges68 silver badges87 bronze badges

Comments

Community · Accepted Answer · 2020-06-20 09:12:55Z

0

Hi check that customer table is available in gym Database. else try this link

edited Jun 20, 2020 at 9:12

CommunityBot

11 silver badge

answered Apr 17, 2017 at 11:03

Yuvaraj

113 bronze badges

Comments

s4turday · Accepted Answer · 2017-04-17 11:06:14Z

0

private void comboBox2_SelectedIndexChanged(object sender, EventArgs e) 
            { 
                SqlCommand cmd = new SqlCommand("insert into customer (name,weight,height,add_class,gender,fees) values(@name,@weight,@height,@add_class,@gender,@fees)", con); 
                cmd.Parameters.AddWithValue("name", this.textBox1.Text); 
                if (con.State == ConnectionState.Closed) 
                con.Open(); 
                cmd.ExecuteNonQuery(); 
                con.Close(); 
            }

edited Apr 17, 2017 at 11:06

answered Apr 17, 2017 at 10:38

s4turday

211 silver badge3 bronze badges

1 Comment

s4turday Over a year ago

change sqlcommand inside as "insert into customer (name,weight,height,add_class,gender,fees) values(@name,@weight,@height,@add_class,@gender,@fees)"

marc_s · Accepted Answer · 2017-04-17 12:07:46Z

0

I found that your connection string declaration is wrong

public string ss = "Data Source=D\\SQLEXPRESS;Initial Catalog=gym;Integrated Security=True";

need to update like below

public string ss = "Data Source=abc\\SQLEXPRESS;Initial Catalog=gym; user id=sa; Password=123456";

Data source will be not be D, It should be Server name.

enter image description here

edited Apr 17, 2017 at 12:07

marc_s

760k186 gold badges1.4k silver badges1.5k bronze badges

answered Apr 17, 2017 at 11:29

pankaj kumar singh

171 silver badge6 bronze badges

Collectives™ on Stack Overflow

How can I insert and save data into database using Visual Studio and C#?

5 Answers 5

1 Comment

Comments

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

Comments

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related