Create method from existing python code

Question

I have this bit of code part of a python script i have to query ldap attributes of users:

try:
    ldap_result_id = l.search(baseDN, searchScope, get_searchFilter(adname), 
retrieveAttributes)
    result_set = []
    while 1:
        result_type, result_data = l.result(ldap_result_id, 0)
        if (result_data == []):
            break
        else:
            ## you could do whatever you want with the individual entry
            ## The appending to list is just for illustration.
            if result_type == ldap.RES_SEARCH_ENTRY:
                result_set.append(result_data)
    for x in result_set:
        print x
except ldap.LDAPError, e:
    print e
    print ldap.LDAPError

How can I clean this up and make it into a reusable function(or is Method the more proper terminology)?

Since you do not intend to produce classes, "function" is the more proper and the only right terminology. — DYZ
– DYZ, Commented Apr 19, 2017 at 5:53
@DYZ In the event i start to use classes would it then be a Method? — xmx
– xmx, Commented Apr 19, 2017 at 14:56

AChampion · Accepted Answer · 2017-04-19 05:46:59Z

1

Identify the variables that can change and make those arguments to a function. Leave the printing and exception handling outside of the function unless you can do something sensible with the exception:

def fn(baseDN, searchScope, adname, retrieveAttributes):
    ldap_result_id = l.search(baseDN, searchScope, get_searchFilter(adname), 
retrieveAttributes)
    result_set = []
    while 1:
        result_type, result_data = l.result(ldap_result_id, 0)
        if (result_data == []):
            break
        else:
            ## you could do whatever you want with the individual entry
            ## The appending to list is just for illustration.
            if result_type == ldap.RES_SEARCH_ENTRY:
                result_set.append(result_data)
    return result_set

baseDN = ???
searchScope = ???
adname = ???
retrieveAttributes = ???
try:
    for x in fn(baseDN, searchScope, adname, retrieveAttributes):
        print x
except ldap.LDAPError, e:
    print e
    print ldap.LDAPError

answered Apr 19, 2017 at 5:46

AChampion

30.5k4 gold badges63 silver badges79 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

xmx Over a year ago

I assume the baseDN = ???, searchScope = ???,adname = ??? and retrieveAttributes = ??? should be omitted from the script?

AChampion Over a year ago

Those are variables that need to be provided, e.g. user input, read from a data store, passed by another application, etc.

xmx Over a year ago

gotcha! Yes, i have those already provided in my python script in another section! Your solution worked wonderfully!

Collectives™ on Stack Overflow

Create method from existing python code

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related