PHP from loop to JSON formatting won't match

Question

I have this array

$data = [ 'admin'=>'1', 'natasha'=>'2', 'demo3'=>'3' ];

When I output it echo json_encode($data); I get {"admin":"1","natasha":"2","demo3":"3"} and this how I need it and it works well!

Now I'm trying to loop data from database like this:

    $data = array();
    foreach(TopicModel::theListofUsers($topic_cat,30) as $row) {                
       $data[]= array($row->user_name=>$row->user_id);  
    }
    header('Content-Type: application/json');
    echo json_encode($data);

But I'm getting this format [{"demo4":"4"},{"demo3":"3"}] but I need {"admin":"1","natasha":"2","demo3":"3"}

I tried many things, pass strings and convert to array or manipulate array but none of it gave me the proper format. Any idea?

mlask · Accepted Answer · 2017-07-13 11:35:28Z

2

$data = array();
foreach(TopicModel::theListofUsers($topic_cat,30) as $row) {                
   $data[$row->user_name] = $row->user_id;
}
header('Content-Type: application/json');
echo json_encode($data);

answered Jul 13, 2017 at 11:35

mlask

3371 silver badge9 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Fabiano · Accepted Answer · 2017-07-13 11:38:40Z

1

To achieve what you want, you need to set the name as the array key inside your foreach loop:

$data = array();
foreach(TopicModel::theListofUsers($topic_cat,30) as $row)
{                
   $data[$row->user_name]= $row->user_id;  
}

header('Content-Type: application/json');
echo json_encode($data);

And I suggest that you escape both key and value of your array to avoid unwanted characters, otherwise your json_encode will fail returning false.

A simply way to do it can be: str_replace("'", "", $row->user_name) and str_replace("'", "", $row->user_id).

answered Jul 13, 2017 at 11:38

Fabiano

5,2192 gold badges30 silver badges31 bronze badges

3 Comments

JoshuaNa Over a year ago

Thanks but I don't think user_name or user_id will ever have quotes in it

Fabiano Over a year ago

Yes, I don't think so too. But this is a good coding practice, you will avoid PHP errors with it. It is defensive programming. Unless you are sure that these data is already treated.

JoshuaNa Over a year ago

so you think in coding is good to do extra things even though are not necessary? I tested it and the system won't let me add ' for usernames

Collectives™ on Stack Overflow

PHP from loop to JSON formatting won't match

2 Answers 2

Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related