Searching an array of Objects

Question

let teams = [
{ name : 'Patriots' },
{ name : 'Dolphins' },
{ name : 'Jets' }, 
{ name : 'Bills' }
]

let search = (name) => {
    for( let i = 0; i < teams.length; i++ ) {
        if( name === teams[i].name ) {
            return teams[i];
        }
        return false;
    }
}
console.log(search('Patriots')); // returns { name : 'Patriots }
console.log(search('Dolphins')); // return false

I am trying to write a search function to search an array of objects. When I search for the first object it returns it. When I search for any other object in the array it return false. Is there a way to have the for loop run completely before moving onto my if else statements or is there a better way to do this?

Put the "return false" outside the for loop

Alex Bieg
– Alex Bieg

2017-07-18 15:47:05 +00:00
Commented Jul 18, 2017 at 15:47 — Alex Bieg
– Alex Bieg, Commented Jul 18, 2017 at 15:47
wow... thanks @AlexBieg

Austin Johnson
– Austin Johnson

2017-07-18 15:48:26 +00:00
Commented Jul 18, 2017 at 15:48 — Austin Johnson
– Austin Johnson, Commented Jul 18, 2017 at 15:48
Haha no worries. It happens to the best of us.

Alex Bieg
– Alex Bieg

2017-07-18 15:49:28 +00:00
Commented Jul 18, 2017 at 15:49 — Alex Bieg
– Alex Bieg, Commented Jul 18, 2017 at 15:49

NickMcB · Accepted Answer · 2017-07-18 15:51:40Z

3

You need to remove 'return false' from within the for loop, this is triggering after the loop has gone through the first value so it is never reaching 2,3,4th property/teams.

let teams = [
    { name : 'Patriots' },
    { name : 'Dolphins' },
    { name : 'Jets' }, 
    { name : 'Bills' }
]

let search = (name) => {
    for( let i = 0; i < teams.length; i++ ) {
        if( name === teams[i].name ) {
            return teams[i];
        }
    }
    // return 'false' if not found
    return false
}
console.log(search('Patriots')); // returns { name : 'Patriots }
console.log(search('Dolphins')); // returns { name : 'Dolphins }
console.log(search('Oranges'));  // returns false

return teams[i]; will stop the loop from continuing once it has found a matching value.

I've added return false after the for loop, so If the team name is not found the function will return 'false'.

edited Jul 18, 2017 at 15:51

answered Jul 18, 2017 at 15:48

NickMcB

9471 gold badge8 silver badges18 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Liam MacDonald Over a year ago

+1 but if the expectation is for it to return false if not found then you need to add return false after the for loop. That way the search either returns the result, or it iterates over the array and then returns false. I'd also suggest using developer.mozilla.org/en/docs/Web/JavaScript/Reference/…

NickMcB Over a year ago

Thanks for pointing that out Liam, ive updated answer to include this scenario.

T4rk1n · Accepted Answer · 2017-07-18 16:00:39Z

1

You can do it with filter and reduce.

const teams = [
    { name : 'Patriots' },
    { name : 'Dolphins' },
    { name : 'Jets' }, 
    { name : 'Bills' }
]
const search = (arr, s) => arr.filter(({name}) => name === s).reduce((p,{name}) => name || p, false) 

console.log(search(teams, 'Patriots'))

answered Jul 18, 2017 at 16:00

T4rk1n

1,47013 silver badges17 bronze badges

Collectives™ on Stack Overflow

Searching an array of Objects

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related