PHP/MYSQL duplicating last row on insert statement

Question

I am getting an unwanted duplicate entry for every last row on an insert statement. Does anyone know why this happens and how I can fix it?

?php
if(isset($_POST['submit'])) {
  $con = mysql_connect("localhost"," "," ");

  if (!$con) {
    die('Could not connect: ' . mysql_error());
  }

  mysql_select_db("database", $con);
  $sql="INSERT INTO table(ID,user) VALUE('$ID','$_POST[user]')";
  $result = mysql_query( $sql,$con );

  if (!mysql_query($sql,$con)) {
    die('Error: ' . mysql_error());
  }

  header( 'Location: index.php?success' ) ;
}
?>

As @oli and @Tatu Ulmanen state, you're running this query twice. However, you might also want to consider specifying a unique compound key in your database table so that it's not possible to have duplicate entries. — John Parker
– John Parker, Commented Dec 23, 2010 at 11:09

Oli · Accepted Answer · 2010-12-23 11:06:08Z

3

if (!mysql_query($sql,$con)) executes the query again.

Should be:

$result = mysql_query( $sql,$con );

if (!$result)

answered Dec 23, 2010 at 11:06

Oli

2,5043 gold badges29 silver badges48 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Tatu Ulmanen · Accepted Answer · 2010-12-23 11:06:14Z

2

You're running the query twice. Try this:

$result = mysql_query( $sql,$con );

if (!$result) {...

answered Dec 23, 2010 at 11:06

Tatu Ulmanen

125k34 gold badges190 silver badges185 bronze badges

Comments

regilero · Accepted Answer · 2010-12-23 11:41:16Z

0

And please sanitize the $_POST before using it ine a query string (mysql_real_escape at least). Maybe you could comment somewhere what is $ID and how you get it.

answered Dec 23, 2010 at 11:41

regilero

30.7k6 gold badges65 silver badges101 bronze badges

Collectives™ on Stack Overflow

PHP/MYSQL duplicating last row on insert statement

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related