php multi level foreach loop remove last comma from loop

Question

hii i have 2 level foreach loop like this and i want to remove last comma from each loop ,

/* Here is the mysql query */
foreach($loop1 as $val1){
   $showvalone = $val1['data1'];
   echo "[".$showvalone;
   /*  Here is the second MySQL query connected with 1st query */
   foreach($loop2 as $val2){
      $showvaltwo[] = $val2['data2'];
   }
   echo implode(",",$showvaltwo); 
   echo "] , ";
}

output of this program :

[ 1
  one ,
  two ,
  three
],
[ 2
  one ,
  two ,
  three
],

And i want like this

[ 1
  one ,
  two ,
  three
],
[ 2
  one ,
  two ,
  three
]

i am already use implode , trim but is remove only one loop not remove second . sol me my problem , thanks .

Just put echo "] , "; inside an if statement? If it is the last item in your for loop do echo "]"; else do echo "] , "; for everything else. — sorifiend
– sorifiend, Commented Sep 6, 2017 at 2:00
reset your $showvaltwo = array() before foreach($loop2 as $val2) — Michael Eugene Yuen
– Michael Eugene Yuen, Commented Sep 6, 2017 at 2:24

BitSmith · Accepted Answer · 2017-09-06 01:46:39Z

1

You can turn the problem around and add the ',' to the start of the next output. There is no need to remove it afterwards.
However you don't want the comma for the first output.

$addComma = ''; // should be empty for the first lines.
foreach($loop1 as $val1){
   $showvalone = $val1['data1'];
   echo $addComma."[".$showvalone;
   /*  Here is the second MySQL query connected with 1st query */
   foreach($loop2 as $val2){
      $showvaltwo[] = $val2['data2'];
   }
   echo implode(",",$showvaltwo); 
   echo "]";
   $addComma = " , "; // any lines following will finish off this output
}

answered Sep 6, 2017 at 1:46

BitSmith

1166 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

dougtesting.net · Accepted Answer · 2017-09-06 00:46:28Z

0

Rather than output the information directly you could put it in to a variable as a string. This will allow you to rtrim the last comma after the loop, then echo the information.

// Declare variable to hold the string of information.
$values = "";

/* Here is the mysql query */
foreach($loop1 as $val1)
{
   $showvalone = $val1['data1'];
   $values .= "[".$showvalone;

   /*  Here is the second MySQL query connected with 1st query */
   foreach($loop2 as $val2)
   {
      $showvaltwo[] = $val2['data2'];
   }

   $values .= implode(",",$showvaltwo); 
   $values .= "] , ";
}

// Remove the last comma and spaces from the string.
$values = rtrim($values, ' , ');

// Output the information.
echo $values;

answered Sep 6, 2017 at 0:46

dougtesting.net

5814 silver badges9 bronze badges

Comments

Pingolin · Accepted Answer · 2019-04-19 11:25:09Z

0

I have my own version in removing "," at the end and instead of adding a "."

$numbers = array(4,8,15,16,23,42);

/* defining first the "." in the last sentence instead of ",". In preparation for the foreach loop */

$last_key = end($ages);

// calling the arrays with "," for each array.
foreach ($ages as $key) :
  if ($key === $last_key) {
    continue; // here's the "," ends and last number deleted.
  }
  echo $key . ", ";
endforeach;

echo end($ages) . '.' ; // adding the "." on the last array

edited Apr 19, 2019 at 11:25

Pingolin

3,4677 gold badges29 silver badges43 bronze badges

answered Apr 19, 2019 at 9:15

Ernesto Jr Montejo

3310 bronze badges

Collectives™ on Stack Overflow

php multi level foreach loop remove last comma from loop

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related