laravel Controller error when using Request in function

Question

I make controller by using php artisan make:controller newsController --resource

And after that when I go to my controller in function index, I want to add Request $request

public function index(Request $request)
{   

}

It's return error:

Declaration of App\Http\Controllers\Admin\NewsController::index(Illuminate\Http\Request $request) should be compatible with App\Http\Controllers\Controller::index()

How to fix it? I try many way but it still didn't work!

EDIT — Controller

namespace App\Http\Controllers\Admin;
use Illuminate\Http\Request;
use App\Http\Controllers\Controller;

UPDATED — Routes

Route::post('admin/news', 'Admin\NewsController@store');
Route::resource('admin/news', 'Admin\NewsController');

Make sure you have "use Illuminate\Http\Request;" as namespace — ankit patel
– ankit patel, Commented Nov 20, 2017 at 5:00

Hiren Gohel · Accepted Answer · 2017-11-20 07:14:23Z

3

It's quite simple, just create your Resource controller without the index route Or Create new get route, like this:

Route::resource('admin/news', 'Admin\NewsController', ['except' => ['index']]);

Then add your route before the resource declaration, something like this:

Route::post('admin/news', 'Admin\NewsController@index');

Route::resource('admin/news', 'Admin\NewsController', ['except' => ['index']]);

Hope this helps you!!

edited Nov 20, 2017 at 7:14

answered Nov 20, 2017 at 5:32

Hiren Gohel

5,0496 gold badges31 silver badges50 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

lagbox · Accepted Answer · 2017-11-20 08:31:10Z

This doesn't require any Laravel work arounds.

Fix:

a) Remove the index method from the base controller

or

b) Make the index method in the base controller take a Illuminate\Http\Request as an argument and use that same method signature in every controller's index method that inherited from the base in the entire application.

or

c) Figure out why there is an index method defined in the base in the first place and, if needed, move it to a trait to use in child classes instead. (allows you to override the method completely)

b is not a good option, it is just to illustrate a point

Issue demonstrated:

class Foo
{
    public function index()
    {
        //
    }
}

class Bar extends Foo
{
    public function index(\Illuminate\Http\Request $request)
    {

    }
}

Declaration of Bar::index(Illuminate\Http\Request $request) should be compatible with Foo::index()

shrekuu · Accepted Answer · 2019-08-21 05:53:14Z

1

You want to override the index action.

You also want to pass parameters into this index action.

The App\Http\Controllers\Controller::index() does not take parameters.

So they are not "compatible".

Try this "helper-funtion" way:

public function index() {

$request = request() // use the helper function

// ...you code here...
}

answered Aug 21, 2019 at 5:53

shrekuu

2,2721 gold badge28 silver badges43 bronze badges

Comments

Ted · Accepted Answer · 2020-04-26 11:15:32Z

0

You can disable index from resources and define route with different method name before or after resource:

    Route::get('resources', 'ResourceController@getResources');
    Route::resource('resources', 'ResourceController', $restResource)->except(['index']);

answered Apr 26, 2020 at 11:15

Ted

4,1868 gold badges63 silver badges88 bronze badges

Collectives™ on Stack Overflow

laravel Controller error when using Request in function

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related