PHP fileupload giving all filenames from array

Question

I've been looking in this for a day or two now. When I upload multiple files to this script, "$finalfilename" gives me back multiple filenames from the second file.

Here's my code:

include ($_SERVER['DOCUMENT_ROOT'] . "/config/config.php");

$valid_extensions = array(
    'jpeg',
    'jpg',
    'png',
    'gif',
    'bmp'
); // valid extensions
$path = $_SERVER['DOCUMENT_ROOT'] . '/assets/uploads/'; // upload directory
$uploadOK = 1;
$album = strip_tags($_POST['newPostForm-Album']);
$i = 0;

foreach($_FILES['NEW-POST-FORM_IMAGES']['name'] as $file)
{
    $imgname = $_FILES['NEW-POST-FORM_IMAGES']['name'][$i];
    $tmpname = $_FILES['NEW-POST-FORM_IMAGES']['tmp_name'][$i];
    $timestamp = time();
    $extension = strtolower(pathinfo($imgname, PATHINFO_EXTENSION));
    $newfilename = sha1(time() . $i);
    $finalfilename = $newfilename . "." . $extension;
    if ($_FILES['NEW-POST-FORM_IMAGES']["size"][$i] > 500000)
    {
        echo "Sorry, your file is too large.";
        $uploadOk = 0;
    }

    if ($uploadOK)
    {
        if (in_array($extension, $valid_extensions))
        {
            $path = $path . strtolower($finalfilename);
            if (move_uploaded_file($tmpname, $path))
            {

                // mysqli_query($con, "INSERT INTO posts VALUES('', '$album', '$finalfilename', '$timestamp')");

                echo $_FILES['NEW-POST-FORM_IMAGES']['name'][$i];
            }
            else
            {
                echo "error!";
            }
        }
    }

    $imgname = "";
    $tmpname = "";
    $timestamp = "";
    $extension = "";
    $newfilename = "";
    $finalfilename = "";
    $i++;
}

As you can see, I tried resetting all the strings at the end before adding $i.

UPDATE

I tried using $file instead of $_FILES (echo $file['name'][$i];) This gives me back this warning: Illegal string offset 'name' in

also the output of the second file ($finalfilename) gives me 'filename'.extention'filename'.extention ea5816965b01dae0b19072606596c01efc015334.jpeg21aa3008f90c89059d981bdc51b458ca1954ab46.jpg

Which need to be separated.

I need to only get the filename of each file separately.

Thank you!

Instead of $_FILES['NEW-POST-FORM_IMAGES']['name'][$i] in your loop you should just use $file I think. — xander
– xander, Commented Dec 7, 2017 at 9:57
@xander as panther said, it is the same, I tried both, thanks for the help anyway ;) — Axel D'Olislager
– Axel D'Olislager, Commented Dec 7, 2017 at 9:59
Still recommend using $file else you could also go for a while loop. — Doomenik
– Doomenik, Commented Dec 7, 2017 at 10:00
What exactly means give's me back multiple filenames from the second file.? Please add a dump from $_FILES['NEW-POST-FORM_IMAGES']['name'] too. — pavel
– pavel, Commented Dec 7, 2017 at 10:01

pavel · Accepted Answer · 2017-12-07 10:14:11Z

2

Problem is in $path variable.

Put $path = $_SERVER['DOCUMENT_ROOT'] . '/assets/uploads/'; into the loop. You can remove variable reseting from the end too.

foreach ($_FILES['NEW-POST-FORM_IMAGES']['name'] as $file) {
    $path = $_SERVER['DOCUMENT_ROOT'] . '/assets/uploads/';
    $imgname = $_FILES['NEW-POST-FORM_IMAGES']['name'][$i];
    $tmpname = $_FILES['NEW-POST-FORM_IMAGES']['tmp_name'][$i];
    $timestamp = time();
    $extension = strtolower(pathinfo($imgname, PATHINFO_EXTENSION));
    $newfilename = sha1(time() . $i);
    $finalfilename = $newfilename . "." . $extension;
    if ($_FILES['NEW-POST-FORM_IMAGES']["size"][$i] > 500000)
    {
        echo "Sorry, your file is too large.";
        $uploadOk = 0;
    }

    if ($uploadOK)
    {
        if (in_array($extension, $valid_extensions))
        {
            $path = $path . strtolower($finalfilename);
            if (move_uploaded_file($tmpname, $path))
            {

                // mysqli_query($con, "INSERT INTO posts VALUES('', '$album', '$finalfilename', '$timestamp')");

                echo $_FILES['NEW-POST-FORM_IMAGES']['name'][$i];
            }
            else
            {
                echo "error!";
            }
        }
    }

    $i++;
}

There are more thing to update, instead of foreach for/while would be better here, or using foreach in else way (use $file in the loop body), etc. Moving $path into loop is easiest way how to fix your problem.

edited Dec 7, 2017 at 10:14

answered Dec 7, 2017 at 10:07

pavel

27.3k11 gold badges47 silver badges63 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Axel D'Olislager Over a year ago

Got it! Thank you for your help!

Collectives™ on Stack Overflow

PHP fileupload giving all filenames from array

1 Answer 1

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related