NodeJS mysql not inserting into table

Question

I have a database with a table called responses described as

 +----------+----------+------+-----+---------+-------+
 | Field    | Type     | Null | Key | Default | Extra |
 +----------+----------+------+-----+---------+-------+
 | user     | char(25) | YES  |     | NULL    |       |
 | response | text     | YES  |     | NULL    |       |
 +----------+----------+------+-----+---------+-------+

When I am inserting into the database such as this:

connection.connect(function(err) {
 if (err) {
     console.error('error connecting: ' + err.stack);
     return;
 }
 console.log('connected as id ' + connection.threadId);
 var sql = "INSERT INTO responses (user, response) VALUES ('test_user', 'A')";
 connection.query(sql, function (err, result) {
     if (err) throw err;
     console.log("1 record inserted");
     connection.end();
 });
 });

It is throwing an error saying Error: Cannot enqueue Query after invoking quit.

I connect to the DB fine in the application, but for some reason this query doesn't work, any suggestions?

can you try only doing this part without the connect part var sql = "INSERT INTO responses (user, response) VALUES ('test_user', 'A')"; connection.query(sql, function (err, result) { if (err) throw err; console.log("1 record inserted"); connection.end(); }); — Amit Wagner
– Amit Wagner, Commented Dec 29, 2017 at 19:59

Amit Wagner · Accepted Answer · 2017-12-29 23:37:11Z

1

you don`t need the connect function as calling query will call connect for you if not connected.

put the connection end outside of the function.

also note the in NodeJs you usually close the connection only when you app closes. its increase the performance as not need to reconnect every new query

 var sql = "INSERT INTO responses (user, response) VALUES ('test_user', 'A')";
connection.query(sql, function (err, result) {
     if (err) throw err;
     console.log("1 record inserted");
   
});
connection.end();

answered Dec 29, 2017 at 23:37

Amit Wagner

3,1843 gold badges23 silver badges39 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Daniel McCrevan Over a year ago

Now when I run this, I get the same error Error: Cannot enqueue Query after invoking quit.. Could this possibly be a DB side permission issue?

Amit Wagner Over a year ago

can it come from anther place in your app ? try remove the connection.end();

Daniel McCrevan Over a year ago

I tried a different query and it seems no query will work no matter where it is placed.

Daniel McCrevan Over a year ago

Fixed the issue, I was calling a connection.end() at the bottom without realizing.

Collectives™ on Stack Overflow

NodeJS mysql not inserting into table

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related