Finding Max Value from Key/Value Object pairs Javascript

Question

I'm stuck on why my Javascript findMaxObjectValue function will not work. Here's what I've come up with:

function findMaxObjectValue(obj) {
    return Object.keys(obj).reduce(function(a, b) {
        return (obj.a > obj.b) ? a : b;
    }, obj[a]);
}

When I run this:

findMaxObjectValue([{Alex: 1}, {Katie: 2}, {Nora: 3}, {Dana: 4}])

It returns '3', when I am hoping for '4'... All help appreciated!

Sean F · Accepted Answer · 2018-01-28 04:00:44Z

1

It's because you are reducing the keys and not the values. It is comparing Alex, Katie, Nora and Dana. Nora comes last lexicographically, so that is the answer.

If you want to sort by the values 1, 2, 3, 4, then use the values() method, not the keys() method.

answered Jan 28, 2018 at 4:00

Sean F

4,62521 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

brk · Accepted Answer · 2018-01-28 04:02:10Z

0

Use Object.values instead of Object.keys

function findMaxObjectValue(obj) {

  var objLargestVal = Object.values(obj).reduce(function(a, b) {
    return (obj[a] > obj[b]) ? a : b;
  });
  for (var keys in objLargestVal) {
    return objLargestVal[keys]
  }
}


console.log(findMaxObjectValue([{
  Alex: 1
}, {
  Katie: 2
}, {
  Nora: 3
}, {
  Dana: 4
}]))

answered Jan 28, 2018 at 4:02

brk

50.3k10 gold badges59 silver badges85 bronze badges

Collectives™ on Stack Overflow

Finding Max Value from Key/Value Object pairs Javascript

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related