Update single document in mongodb using node js

Question

I am new in node and mongodb and I am trying to update the user password in the mongo database using node. I am getting the following error --

errmsg: 'After applying the update to the document {_id: ObjectId(\'5a4f50381a1152ec09277578\') , ...}, the (immutable) field \'_id\' was found to have been altered to _id: ObjectId(\'5a739493c592356f1b5a78b6\')' }

My code in models/accounts.js is

AccountSchema.static('passchange', function (password, callback) {
var that = this;
if (typeof userobj!="undefined") {
        console.log("User Object");
        console.log(userobj._id); //I am getting the user id here

        that.findOne({_id:userobj._id}, function (err, user) {
            if (!user) {
                console.log("No User");
                return callback(null, false);
            }
            else
            {
                var salt = this.salt = bcrypt.genSaltSync(10);
                var hash = bcrypt.hashSync(password, salt);

                var updatepwd = new that({
                    salt: salt,
                    hash: hash
                });
                var conditions = { _id: userobj._id }
                that.updateOne(conditions,updatepwd, function (err, savePassword) {
                    if (err)
                    {
                        console.log("err");
                        console.log(err);
                        return callback({err: err}, false);
                    } else {
                        console.log("savePassword._id");
                        console.log(savePassword._id);
                        //return callback(null, {_id : savePassword._id});
                    }
                });
            }
        });

    }
});

Any help is highly appreciated. Thanks in advance.

What is the value of "this?" And what is a "new" that? Those names aren't very descriptive. — Jeff Matthews
– Jeff Matthews, Commented Feb 1, 2018 at 22:45
Are you certain that updatepwd shouldn't be { '$set': { salt: salt, hash: hash } } instead? My understanding is that you're simply overwriting the entire document as opposed to updating specific values. The $set operator would fix this problem. — B. Fleming
– B. Fleming, Commented Feb 1, 2018 at 22:53

B. Fleming · Accepted Answer · 2018-02-01 23:12:15Z

1

For the sake of documenting the solution:

As per the discussion in the comments, the problem appeared to be that the original document was being completely overwritten by the update, as opposed to only the hash and salt fields being updated. The appropriate fix was to update the updatepwd value to the following:

var updatepwd: { $set: {
    salt: salt,
    hash: hash
}};

The $set operator ensures that only salt and hash get updated, and thus the _id field (along with the rest of the data) remains untouched.

answered Feb 1, 2018 at 23:12

B. Fleming

7,2601 gold badge22 silver badges37 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

JChandler · Accepted Answer · 2018-02-01 22:55:30Z

0

you may have to update the new operator because you are producing a new ID when you don't intend to change the ID, just the password. Try to follow the logic below instead of the new operator.

items.forEach(function (product) { //update or create new products

// Es6 assign
var productToUpdate = {};
productToUpdate = Object.assign(productToUpdate, product._doc);
delete productToUpdate._id;

Product.findOneAndUpdate({product_id: product.product_id}, productToUpdate, 
                     {upsert: true}, function (err) {
if (err)  return updateDBCallback(err);
   updateDBCallback(null, 'saved');
});
});

answered Feb 1, 2018 at 22:55

JChandler

111 bronze badge

Collectives™ on Stack Overflow

Update single document in mongodb using node js

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related