Angular js cannot save cookies instead it throw undefined error

Question

hi I try to save in cookies after a web response. Here is my code

angular.module('myApp').controller('SignInController',['WebService',function(WebService, $cookies){
    this.formData = {};
    this.signIn = function(formData){
        WebService.login(formData).then(function successCallback(data){
            //console.log("Success callback:"+JSON.stringify(data));
            var response = data.data;
            var message = response['message'];
            if (message == 'Success') {
                $cookies.put("id", response['id']); 
                $cookies.put("number", response['number']); 
            }else{

            }

            console.log('Message:'+message+" id:"+ $cookies.get('id'));
        },function errorCallback(error){
            console.log("Error"+JSON.stringify(error));
        });
        this.formData = {};
    };
}]);

i have included ngCookies as module while creating main angular module. What I'm doing wrong here? Anyone show me correct way. Thank you.

Fix your injections: ['WebService', '$cookies',function(WebService, $cookies) — Aleksey Solovey
– Aleksey Solovey, Commented Feb 8, 2018 at 13:27
,['WebService',function(WebService, $cookies) - what about add '$cookies' after 'Webservice'? — happyZZR1400
– happyZZR1400, Commented Feb 8, 2018 at 13:28

Praveen Soni · Accepted Answer · 2018-02-08 14:14:40Z

1

array containing all string of all arguments is good approach to handle dependency injection (DI) after your code is minified.

angularJs use Named_parameter in DI, you can understand how DI works by this blog post.

when you minified you angularJs file, ($http, $scope) converted to (a, b) and DI can't understand them.
$inject is my recommended way to handle this situation. its looks clean. (personal opinion, can be vary). and try to write code which easily maintainable.

var app = angular.module('myApp', []);
SignInController.$inject = ['WebService', '$cookies'];
app.controller('SignInCtrl', SignInController);

function SignInController(WebService, $cookies){
  this.formData = {};
  this.signIn = signIn;

  function signIn(formData) {
    WebService.login(formData)
      .then(successCallback, errorCallback);

    function errorCallback(error){
        console.log("Error"+JSON.stringify(error));
    }

    function successCallback(data){
       var response = data.data;
       var message = response['message'];
       if (message == 'Success') {
         $cookies.put("id", response['id']); 
         $cookies.put("number", response['number']); 
       }
    }
    this.formData = {};
};

edited Feb 8, 2018 at 14:14

answered Feb 8, 2018 at 13:49

Praveen Soni

7908 silver badges22 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Praveen Soni Over a year ago

this is good answer on $inject stackoverflow.com/questions/18698963/…

e.k Over a year ago

I think order is first function then $inject then controller correct?

Praveen Soni Over a year ago

@e.k this is right, read hoisting

Collectives™ on Stack Overflow

Angular js cannot save cookies instead it throw undefined error

1 Answer 1

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related