View data from database using MVC & Entity Framework

Question

I am trying to view list of items from database ( I am using Entity Framework).

My Repository method:

public List<string> getListOfItems(int i)
{
    return (from x in db.Items where x.ID == i select x.Text).ToList();
}

My Controller:

public ActionResult Index()
{
    var itemOutput = repo.getListOfItems(1); // I just put 1 since I didn't know how to specify "i" - However theoretically it should return first item in database but its not
    ViewBag.itemOutput = itemOutput ;

    return View();
}

Model:

public class items
{
    [Key]
    public int ID{ get; set; }
    public string name{ get; set; }
    public string quantity{ get; set; }
}

ItemModel:

public class itemModels
{ 
    public List<List<string>> itemData{ get; set; }
}

View:

@foreach (var item in ViewBag.itemOutput )
{
    <table id="t01">
        <tr>
            <td>@item.name</td>
        </tr>
    </table>
}

it is not showing the items from the database. technically it should show first item (e.g. Camera) — Warda
– Warda, Commented Mar 20, 2018 at 14:17
Have you check data is retrive from the database, have you check correct database is pointing? — programtreasures
– programtreasures, Commented Mar 20, 2018 at 14:18
Why are you not using a proper model here? Don't use the ViewBag unless you absolutely have to. If you don't know how to pass a model to your view, then you should go back to basics and follow some tutorials first. — DavidG
– DavidG, Commented Mar 20, 2018 at 14:24
Yes, 1) don't use ViewBag, 2) do use a ViewModel, 3) GetList(ID) will always return a list of 0 or 1 items. — Henk Holterman
– Henk Holterman, Commented Mar 20, 2018 at 14:26

Rafalon · Accepted Answer · 2018-03-20 14:39:39Z

2

Answer:

ViewBag.itemOutput is a List<string> which makes item a string.

Therefore, use @item instead of @item.name (as string does not have .name property) in your view:

@foreach (var item in ViewBag.itemOutput )
{
    <table id="t01">
        <tr>
            <td>@item</td>
        </tr>
    </table>
}

Also, to get the full list, you could do:

public List<string> getListOfItems()
{
    return (from x in db.Items select x.Text).ToList();
}

And then just call getListOfItems() with no param.

Random comments:

1) Don't use plural for class name, unless the class is somewhat a collection of things

--> public class item // without s

2) You said in comments that items are full varchar which is untrue as per your class definition (you have ID, name & quantity).

3) Using string for quantity is a bit weird.

4) You could indeed change your getListOfItems method to:

public List<item> getListOfItems()
{
    return (from x in db.Items select x).ToList();
    // which can be simplified to:
    // return db.Items.ToList();
}

but you should then change your view back to @item.name.

This would however allow you to do:

@foreach (var item in ViewBag.itemOutput )
{
    <table id="t01">
        <tr>
            <td>@item.name</td>
            <td>@item.quantity</td>
        </tr>
    </table>
}

5) You have an ItemModel but you are not using it. You could modify it and use it instead of the ViewBag.

edited Mar 20, 2018 at 14:39

answered Mar 20, 2018 at 14:22

Rafalon

4,5702 gold badges20 silver badges35 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Warda Over a year ago

Great! :) it worked but at the moment in my controller, I've put var itemOutput = repo.getListOfItems(1); so its returning first item how can I instead loop through my items in my database table??

dr. Over a year ago

from x in db.Items where x.ID == i will return one item with the ID == 1. You are asking for a single item and returning it in a list.

Rafalon Over a year ago

@Warda I edited my answer to add the get the full list part

Warda Over a year ago

Perfect! Thank you so much! :)))

Rafalon Over a year ago

@Warda glad it helped you :) I edited my answer to add some comments

int21h · Accepted Answer · 2018-03-20 14:22:12Z

0

getListOfItems() returns a list of string, but you're referring to an actual object in ViewBag.itemOutput

Instead of select x.Text do a select x, and make the return value List<items>

public List<items> getListOfItems(int i)
{
    return (from x in db.Items where x.ID == i select x).ToList();
}

Then you can keep your razor template the same to refer to @item.name

edited Mar 20, 2018 at 14:22

answered Mar 20, 2018 at 14:17

int21h

8397 silver badges15 bronze badges

3 Comments

Warda Over a year ago

yeah the items in my database is varchar - all strings. so what do you suggest??

int21h Over a year ago

What I'm saying is your Razor template is trying to reference a full item, but you're only returning back strings from the repository.

dr. Over a year ago

@int21h is correct. Your action method and the view do not match.

Collectives™ on Stack Overflow

View data from database using MVC & Entity Framework

2 Answers 2

Answer:

Random comments:

5 Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Answer:

Random comments:

5 Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related