Java array loop method returns last value in array

Question

I'm making a program to determine who has the fastest time in a marathon out of an array of times and one of corresponding names. In order to make them match up I return the index of the lowest time instead of the value of the index. When I return the value of the index instead of the index it returns the correct name and time, however, when returning the index it returns the last value in both arrays.

package Lec3;

public class Marathon 
{
    public static void main (String[] arguments) 
    {
        String[] names = 
        {
            "Elena", "Thomas", "Hamilton", "Suzie", "Phil", "Matt", "Alex",
            "Emma", "John", "James", "Jane", "Emily", "Daniel", "Neda",
            "Aaron", "Kate"
        };

        int[] times = 
        {
            341, 273, 278, 329, 445, 402, 388, 275, 243, 334, 412, 393, 299,
            343, 317, 265
        };

        for (int i = 0; i < names.length; i++) 
        {
            System.out.println(names[i] + ": " + times[i]);
        }

        int key = firstPlace(times, names);

        System.out.println("In first place is " + names[key] + " with a time of " + times[key] + " minutes!");

    }

    public static int firstPlace(int[] time, String[] names)
    {
        int i;
        int bestTime = 1000;
        int firstValue = 0;

        for(i = 0; i < time.length; i++)
        {
            if(time[i] < bestTime)
            {
                firstValue = i; 
            }
        }
        return firstValue;
    }
}

better solution -> use hash

A J
– A J

2018-05-17 01:12:56 +00:00
Commented May 17, 2018 at 1:12 — A J
– A J, Commented May 17, 2018 at 1:12

John Kugelman · Accepted Answer · 2018-05-17 00:42:01Z

2

for(i = 0; i < time.length; i++)
{
    if(time[i] < bestTime)
    {
        firstValue = i; 
    }
}

In this loop you don't update bestTime so the times are all compared against the initial value of 1000. They're all smaller leading to a victory for the last one.

answered May 17, 2018 at 0:42

John Kugelman

365k70 gold badges555 silver badges600 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

nox Over a year ago

Edit: I understand what you mean now in that I don't update bestTime and am only comparing it against the initial value. Thank you for your help!

Elliott Frisch · Accepted Answer · 2018-05-17 00:45:18Z

2

You have a loop in main where you iterate names to display all of the names and times. You can find the lowest key in that loop. Like,

int key = 0;
for (int i = 0; i < names.length; i++) {
    System.out.println(names[i] + ": " + times[i]);
    if (times[i] < times[key]) {
        key = i;
    }
}
System.out.println("In first place is " + names[key] + " with a time of " + times[key] + " minutes!");

Or, in your current method, change

if(time[i] < bestTime)

to

if (time[i] < time[firstValue])

and eliminate bestTime.

answered May 17, 2018 at 0:45

Elliott Frisch

202k20 gold badges166 silver badges265 bronze badges

1 Comment

Dave Newton Over a year ago

@nox Get out a pencil and paper and write down what's happening every loop iteration: play computer.

Collectives™ on Stack Overflow

Java array loop method returns last value in array

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related