ASP.Net MVC - String.Join()

Question

I want to print all Records at once, and for this I used String.Join(). However, the problem is I cant make New Line when I want print all records in DropDownList and as you see in Screenshots. Instead, it select all at once, but I want select one-by-one, like normal DropDownList.

Can anyone please help me or point me in the right direction at what did I wrong?

Here's what I have so far

ViewModel:

public OrdreRMA OrdreRMAs { get; set; }

public class OrdreRMA
{
  public OrdreRMA(List<string> SerialNoInvoiceOrdrelineDeliveryClose)
    {
        this.SerialNoInvoiceOrdrelineDeliveryClose = SerialNoInvoiceOrdrelineDeliveryClose;

    }

    public List<string> SerialNoInvoiceOrdrelineDeliveryClose { get; set; }

}

Controller:

Serial = data.Item_Ledger_Entry
  .Where(ledger => ledger.Document_No_ == t.Document_No_)
  .Where(ledger => ledger.Document_Line_No_ == t.Line_No_)
  .ToList(),
        
var bla4 = col2.Select(t => new OrdreRMA
{
 SerialNoInvoiceOrdrelineDeliveryClose = t.Serial.Select(x => x.Serial_No_).ToList(),
}

1.View (First I used , ):

@{
  var SerialNos = 
    String.Join(",",Model.OrdreRMAs.SerialNoInvoiceOrdrelineDeliveryClose);  
    }

    <div class="col-md-3">
      <div class="form-group">
      <label>Serial number</label>
    @if (SerialNos == "")
    {
      <input name="ikketilgængelig" id="ikketilgængelig" class="form-control border-input disabled"  value="not available">
    }

  else
  {
      <select class="form-control border-input" id="ddlSerial">
      <option value="@SerialNos">@SerialNos</option>
      </select>
    }
  </div>
</div>

Result 1:

2.View (Second I used Environment.NewLine):

@{
  var SerialNos = 
    String.Join(Environment.NewLine,Model.OrdreRMAs.SerialNoInvoiceOrdrelineDeliveryClose);  
    }

   <div class="col-md-3">
     <div class="form-group">
      <label>Serial number</label>
   @if (SerialNos == "")
    {
     <input name="ikketilgængelig" id="ikketilgængelig" class="form-control border-input disabled"  value="not available">
    }

 else
  {
     <select class="form-control border-input" id="ddlSerial">
     <option value="@SerialNos">@SerialNos</option>
     </select>
    }
  </div>
</div>

**Result 2**: 

[![Result #2][2]][2]

**3.View (instead using `String.Join`, I used `Foreach`)**:

```html
   <div class="col-md-3">
     <div class="form-group">
      <label>Serial number</label>
   @if (SerialNos == "")
    {
     <input name="ikketilgængelig" id="ikketilgængelig" class="form-control border-input disabled"  value="not available">
    }

 else
  {
    @foreach (var item in Model.OrdreRMAs.SerialNoInvoiceOrdrelineDeliveryClose)
     {
  <select class="form-control border-input" id="ddlSerial">
   <option value="@item">@item</option>
   </select>
    }
 </div>
  }
  </div>
</div>

Result 3:

You've got the <select> tags inside the loop. Put them outside so you only add options in the loop. — Reinstate Monica Cellio
– Reinstate Monica Cellio, Commented Sep 6, 2018 at 11:56
Why are you not just using the @Html.DropDownListFor() method? — user3559349
– user3559349, Commented Sep 6, 2018 at 12:05
Refer the code in this question for a typical example (and I suggest you go to the mvc site and work through the tutorials to learn the basics of generating views in mvc) — user3559349
– user3559349, Commented Sep 6, 2018 at 12:14
If you mean the other error - then you use if (Model.OrdreRMAs.SerialNoInvoiceOrdrelineDeliveryClose.Any()) { @Html.DropDownListFor(...) } else { @Html.TextBoxFor(...) } — user3559349
– user3559349, Commented Sep 6, 2018 at 12:22

Pranav Singh · Accepted Answer · 2018-09-06 11:58:23Z

1

Try to put select out side foreach loop

<select class="form-control border-input" id="ddlSerial">
 @foreach (var item in Model.OrdreRMAs.SerialNoInvoiceOrdrelineDeliveryClose)
 {
       <option value="@item">@item</option>     
  }
</select>

answered Sep 6, 2018 at 11:58

Pranav Singh

20.3k32 gold badges83 silver badges109 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Dmitry Korolev · Accepted Answer · 2018-09-06 11:59:06Z

1

You are putting foreach in a wrong place.

<select class="form-control border-input" id="ddlSerial">
@foreach (var item in Model.OrdreRMAs.SerialNoInvoiceOrdrelineDeliveryClose)
{  
     <option value="@item">@item</option>
}
</select>

answered Sep 6, 2018 at 11:59

Dmitry Korolev

6854 silver badges20 bronze badges

Comments

KyleMit · Accepted Answer · 2023-02-15 15:45:23Z

0

How about making an array of List<string> in controller.

And later using it as @String.Join(",", @item.arrayname) in Razor?

edited Feb 15, 2023 at 15:45

KyleMit♦

31k74 gold badges517 silver badges712 bronze badges

answered Mar 15, 2019 at 10:15

sapana

3162 silver badges7 bronze badges

Collectives™ on Stack Overflow

ASP.Net MVC - String.Join()

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related