Passing function argument into sql query

Question

I have a weird issue here. I'm passing an ID from a controller into a function file in order to use it in the query. Passing the ID works, and I've dumped it to make sure it's the actual ID I expect and it is.

The problem is, when I add a where clause to my sql, literally only changing the one line, I get the error:

Parse error: syntax error, unexpected '$result' (T_VARIABLE), expecting function (T_FUNCTION)

Here is the working version (though obviously it's a broad query)

public function grabList(int $id)
  {

      $sql = "
        SELECT *
        FROM schemaTest.List L
          INNER JOIN schemaTest.user u
            ON l.user_id = u.ID
          ";
    }

      $result = DB::connection('odbc')->select(DB::raw($sql));
      return $result;

  }

But when I add the where clause that uses the ID passed into the function, I get the error.

public function grabList(int $id)
  {

      $sql = "
        SELECT *
        FROM schemaTest.List L
          INNER JOIN schemaTest.user u
            ON l.user_id = u.ID
        WHERE u.ID = {$id} 
          ";
    }

      $result = DB::connection('odbc')->select(DB::raw($sql));
      return $result;

  }

I'm assuming it's because of the syntax I'm using to try and use the function argument in the query. Any ideas?

First things if you are using laravel, why are you using RAW sql query ? What is the point in using a framework then. I would suggest you to use eloquent. Here is the official document laravel.com/docs/5.6/eloquent on how to use so — user7747472
– user7747472, Commented Sep 7, 2018 at 5:19

Wreigh · Accepted Answer · 2018-09-07 05:09:39Z

1

Are you sure the first one is working fine? Because you have a syntax mistake.

public function grabList(int $id)
{

    $sql = "
        SELECT *
        FROM schemaTest.List L
          INNER JOIN schemaTest.user u
            ON l.user_id = u.ID
        WHERE u.ID = {$id} 
          ";
} // <-- remove this, that would end the function block
// thus causing the error here, unexpected `$result`
     $result = DB::connection('odbc')->select(DB::raw($sql));
      return $result;

}

answered Sep 7, 2018 at 5:09

Wreigh

3,29719 silver badges40 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Whisou138 Over a year ago

Thank you, I somehow missed that. So now the page does load again, but still now results. If I copy the query and run it manually with a number instead of the variable though, it returns results

Jignesh Joisar · Accepted Answer · 2018-09-07 07:50:02Z

1

try to this one

public function grabList(int $id)
    {

        $sql = "
            SELECT *
            FROM schemaTest.List L
            INNER JOIN schemaTest.user u
            ON l.user_id = u.ID
            WHERE u.ID = :uid ";

          $result = DB::connection('odbc')->select(DB::raw($sql),['uid' => $id]);
          return $result;

    }

answered Sep 7, 2018 at 7:50

Jignesh Joisar

15.4k6 gold badges69 silver badges61 bronze badges

Comments

Raushan Singh · Accepted Answer · 2018-09-07 05:02:07Z

0

why u use syntax like core .use laravel synatx for query if u use second database please define in .env and config>database.php

use link http://fideloper.com/laravel-multiple-database-connections

answered Sep 7, 2018 at 5:02

Raushan Singh

1,1302 gold badges9 silver badges19 bronze badges

3 Comments

Raushan Singh Over a year ago

stackoverflow.com/questions/31847054/…

Whisou138 Over a year ago

But that doesn't explain why the query works perfectly fine without the one line of the where clause

Raushan Singh Over a year ago

use have use List L INNER JOIN schemaTest.user u ON l.user_id = u.ID here l is small letter use same as capital L

Bernie · Accepted Answer · 2018-09-07 05:50:55Z

0

I am not 100% sure how you are passing $id, but maybe you need the quotes in the SQL query?

WHERE u.ID = '{$id}'

edited Sep 7, 2018 at 5:50

Bernie

5,0855 gold badges43 silver badges74 bronze badges

answered Sep 7, 2018 at 5:05

Defiant_1

161 bronze badge

Comments

Raushan Singh · Accepted Answer · 2018-09-29 23:27:20Z

0

Just looking at the number of braces, it doesn't parse. You have two closing braces and one opening brace which means that $result isn't contained in the function. Hence Parse error: syntax error, unexpected '$result'.
Jignesh Joisar typed the correct method just now.

edited Sep 29, 2018 at 23:27

Raushan Singh

1,1302 gold badges9 silver badges19 bronze badges

answered Sep 7, 2018 at 7:55

increddibelly

1,2691 gold badge15 silver badges25 bronze badges

Collectives™ on Stack Overflow

Passing function argument into sql query

5 Answers 5

1 Comment

Comments

3 Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

Comments

3 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related