Incorrect syntax for insert query

Question

I'm using JavaScript and PostgreSQL and I'm wondering if the code and syntax is right written because I'm getting strange errors in different situations.

Example:

function putDbEvents({ description, creatorId, attendeeId }) {
  return pool
    .query(`INSERT INTO events (${description}, ${creatorId}), ${attendeeId}`)
    .then(() => pool.end())
    .catch(console.log);
}

My questions:

should it be {} at the first row of function? I think only ()?
should it be like that insert into or maybe like this INSERT INTO events ('description', creatorId, attendeeId) VALUES then (${}...

This is the create table code:

const createEventsRes = await pool.query(
  "CREATE TABLE IF NOT EXISTS events (id serial PRIMARY KEY, description TEXT, creatorId INTEGER, attendeeId INTEGER)"
);

I wanna create a table so every time you add something it should add an id to it automatically and you just pass description, id, id, to it and the fourth is optional so not needed in this case, and want to see if the syntax is right.

better visible: gyazo.com/cb7eb4bdf5c424f4e51c87cb06a0670e gyazo.com/de80545e03f4a503553e605611a65fe8 — user9056339
– user9056339, Commented Sep 25, 2018 at 15:54

The Impaler · Accepted Answer · 2018-09-25 17:38:23Z

1

You need to name the columns when inserting:

INSERT INTO events (description, creatorid, attendeeid) 
  values (${description}, ${creatorId}), ${attendeeId})

It's a good practice. And it's also required when you are omitting columns (id in this case).

edited Sep 25, 2018 at 17:38

answered Sep 25, 2018 at 16:01

The Impaler

49.3k10 gold badges50 silver badges90 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user9056339 Over a year ago

Should it be with ` as well? ` like this: and should it also be {} inside of ()? function putDbEvents({ description, creatorId, attendeeId }) { return pool .query(INSERT INTO events (description, creatorid, attendeeid) values (${description}, ${creatorId} ${attendeeId}) .then(() => pool.end()) .catch(console.log); }

user9056339 · Accepted Answer · 2018-09-26 09:03:40Z

0

Nvm, I solved it.

function putDbEvents(description, creatorid, attendeeid ) { return pool .query(INSERT INTO events (description, creatorid, attendeeid) values ($1, $2, $3), [description, creatorid, attendeeid]) .then(() => pool.end()) .catch(console.log); }

answered Sep 26, 2018 at 9:03

user9056339

Collectives™ on Stack Overflow

Incorrect syntax for insert query

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related