String manipulation in foreach powershell

Question

The output of this code is confusing me. I'm almost positive it's my logic on this.

I want to loop through the $stringToEdit Variable and replace the 'replace' text with an element of the $ip collection.

The output does give three blocks as expected but the 'replace' has ALL three of the elements. I thought it should only be each element. What am I doing wrong?

Code is below

$ip = @('172.168.1.1','172.168.3.1','172.168.2.1')
$stringToEdit = @"
    {
        address : replace
        interface : 'nic0'
        policy : 'allow'
        prefix : 32
    },
"@
$array = @()
$array = ForEach($entry in $ip) {
    $stringToEdit -replace "replace","$ip"
}
$array

Output is

{
    address : 172.168.1.1 172.168.3.1 172.168.2.1
    interface : 'nic0'
    policy : 'allow'
    prefix : 32
},
{
    address : 172.168.1.1 172.168.3.1 172.168.2.1
    interface : 'nic0'
    policy : 'allow'
    prefix : 32
},
{
    address : 172.168.1.1 172.168.3.1 172.168.2.1
    interface : 'nic0'
    policy : 'allow'
    prefix : 32
},

Jordan · Accepted Answer · 2018-09-25 23:07:36Z

1

You use the wrong variable in your foreach block Replace this line:

$stringToEdit -replace "replace","$ip"

With this:

$stringToEdit -replace "replace","$entry"

answered Sep 25, 2018 at 23:07

Jordan

4132 silver badges6 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Dabang · Accepted Answer · 2018-09-25 23:09:40Z

0

replace $ip with $entry

$stringToEdit -replace "replace","$entry"

answered Sep 25, 2018 at 23:09

Dabang

411 silver badge8 bronze badges

2 Comments

Henry Over a year ago

Can you expand a bit on why your solution solves the problem?

Sanwil9 Over a year ago

I wanted this to use this to as a piece of code for a tool to add new entries in to a firewall. The code takes the string and the only thing that changed is the part i put replace in. I then to looped through each ip in the list and replaced the 'replace' text with the ip and then I added it to the array so in the end the output is showing what I want and I can just use this code in correlation with other code to add new entries on the fly or with a csv.

Collectives™ on Stack Overflow

String manipulation in foreach powershell

2 Answers 2

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related