Mysql Insert Problem

Question

It works perfectly fine when the values inserted contain only numbers such as "728011955", but it fails to insert if the values contain any letters such as "1lKw7Rcc1iM8WB9c".

Below is the query that fails.

  $query = ("INSERT INTO $tbl_name VALUES ($key, $timestamp, $use)");

The mysqlerror() output is below.

Unknown column '1lKw7Rcc1iM8WB9c' in 'field list'

Help! :)

Cfreak · Accepted Answer · 2011-03-10 01:45:35Z

7

You have to quote your parameters.

$query = ("INSERT INTO $tbl_name VALUES ('$key', '$timestamp', '$use')");

However you read up on SQL injection attacks as this query is likely vulnerable to them if those variables are coming from outside your program.

answered Mar 10, 2011 at 1:45

Cfreak

19.4k6 gold badges52 silver badges64 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Brandon Over a year ago

We have a winner! It works now! Thank you, Cfreak! High five!

Ted Hopp Over a year ago

It's generally better to use parameter binding than to interpolate the values directly into the query.

ubiquibacon Over a year ago

@Ted Hopp or prepared statements.

Cfreak Over a year ago

Yes prepared statements are definitely the way to go.

Stephane Gosselin · Accepted Answer · 2011-03-10 02:13:58Z

0

Not to be nitpicking but why the outer parentheses? Ie this would work just as well and be easier to read:

$query = "INSERT INTO $tbl_name VALUES ('$key', '$timestamp', '$use')";

As for your error, numeric values should not be quoted (like maybe your key and timestamp values), same for the table name. String types on the other hand need quotes.

While others have mentioned parameter binding and prepared statements to make your sql more secure, yet another possibility is to use sprintf.

edited Mar 10, 2011 at 2:13

answered Mar 10, 2011 at 1:59

Stephane Gosselin

9,1485 gold badges45 silver badges68 bronze badges

Collectives™ on Stack Overflow

Mysql Insert Problem

2 Answers 2

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related