Filling a character array with characters from a string

Question

I'm trying to fill an array with characters from a string inputted via console. I've tried the code bellow but it doesnt seem to work. I get Index out Of Range exception in the for loop part, and i didn't understand why it occured. Is the for loop range incorrect? Any insight would be greatly appreciated

            Console.WriteLine("Enter a string: ");
            var name = Console.ReadLine();

            var intoarray = new char[name.Length];
            for (var i = 0; i <= intoarray.Length; i++)
            {
                intoarray[i] = name[i];
            }
            foreach (var n in intoarray)
                Console.WriteLine(intoarray[n]);

also, as you start from 0, you need to stop at intoarray.Length - 1, so your for-loop should by like for (var i = 0; i < intoarray.Length; i++) — vasily.sib
– vasily.sib, Commented Oct 5, 2018 at 3:33

Sir Rufo · Accepted Answer · 2018-10-05 04:09:28Z

9

using ToCharArray() strings can be converted into character arrays.

Console.WriteLine("Enter a string: ");
var name = Console.ReadLine();

var intoarray= name.ToCharArray();

foreach (var n in intoarray)
    Console.WriteLine(n);

if you are using foreach, you should wait for the index to behave as if you were taking the value.

Console.WriteLine(n);

edited Oct 5, 2018 at 4:09

Sir Rufo

19.3k3 gold badges47 silver badges79 bronze badges

answered Oct 5, 2018 at 3:05

go..

9437 silver badges15 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

NitinSingh · Accepted Answer · 2018-10-05 03:06:37Z

3

Since arrays start at 0 and you are counting inclusive of length, the last iteration will exceed the bounds. Just update the loop conditional to be less than length rather than less than or equal to..

answered Oct 5, 2018 at 3:06

NitinSingh

2,0781 gold badge21 silver badges36 bronze badges

Comments

Bill Horvath · Accepted Answer · 2018-10-05 03:09:03Z

2

I like snn bm's answer, but to answer you question directly, you're exceeding the length of the input by one. It should be:

        for (var i = 0; i <= intoarray.Length - 1; i++)

(Since strings are zero-indexed, the last character in the underlying array is always going to be in the position of arrayLength - 1.)

answered Oct 5, 2018 at 3:09

Bill Horvath

1,83615 silver badges27 bronze badges

Comments

Ron.Shi · Accepted Answer · 2018-10-05 04:14:43Z

1

1: the iteration should be for (var i = 0; i < intoarray.Length; i++)
2: the code

foreach (var n in intoarray) Console.WriteLine(intoarray[n]);

also throws an exception, for "n" is a character in the array while it's used as array index.
3: In addition there's a much easier way to convert string to char array

var intoarray = name.ToCharArray();

Here's the result

edited Oct 5, 2018 at 4:14

answered Oct 5, 2018 at 4:08

Ron.Shi

112 bronze badges

Comments

ksdev · Accepted Answer · 2018-10-05 03:51:57Z

0

Here is your mistake. There are so many options to represent i < intoarray.Length.

for (var i = 0; i < intoarray.Length; i++) // original was i <= intoarray.Length in your code
{
    intoarray[i] = name[i];
}

answered Oct 5, 2018 at 3:51

ksdev

568 bronze badges

Comments

Gauravsa · Accepted Answer · 2018-10-05 04:17:35Z

-1

With linq:

  // Select all chars
  IEnumerable<char> intoarray =  
    from ch in name  
      select ch;  // can use var instead of IEnumerable<char>

    // Execute the query  
    foreach (char temp in intoarray)  
        Console.WriteLine(temp);

answered Oct 5, 2018 at 4:17

Gauravsa

6,6382 gold badges25 silver badges33 bronze badges

Collectives™ on Stack Overflow

Filling a character array with characters from a string

6 Answers 6

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related