if-else inside for loop not working in python

Question

I am writing a simple Python script with if-else condition in a for a loop by reading inputs line by line from a text file. Below is my script. I should get the expected output. Please help! My env.txt contains:

DEV01
DEV02
UAT01
UAT02

Here is the code:

with open("env.txt") as envnames:
    for eachenv in envnames:
        if eachenv=="DEV01" or "DEV02":
            eachenv="dev"
            print (eachenv)
        elif eachenv=="UAT01" or "UAT02":
            eachenv="uat"
            print(eachenv)
        else :
            print('')

Expected:

dev
dev
uat
uat

actual:

dev
dev
dev
dev

please add input file

Talha Israr
– Talha Israr

2019-01-19 12:56:35 +00:00
Commented Jan 19, 2019 at 12:56 — Talha Israr
– Talha Israr, Commented Jan 19, 2019 at 12:56
@TalhaIsrar Unnecessary; problem is clear

Lightness Races in Orbit
– Lightness Races in Orbit

2019-01-19 12:58:17 +00:00
Commented Jan 19, 2019 at 12:58 — Lightness Races in Orbit
– Lightness Races in Orbit, Commented Jan 19, 2019 at 12:58

Mehrdad Pedramfar · Accepted Answer · 2019-01-19 13:44:07Z

6

The problem is if eachenv=="DEV01" or "DEV02".

you can not check like this. the result will be True if eachenv=="DEV01" otherwise the rusult will be "DEV02", not False. you should go like this:

if eachenv in ["DEV01", "DEV02"]:

also change for eachenv in envnames: to:

for eachenv in envnames.readlines():

edited Jan 19, 2019 at 13:44

answered Jan 19, 2019 at 13:07

Mehrdad Pedramfar

11.1k4 gold badges43 silver badges61 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Sivakumar Kayaroganam Over a year ago

This gives me empty output

Mehrdad Pedramfar Over a year ago

I think all of the solutions here may give you an empty output, because eachenv is not "DEV01" or "DEV01". I think it has an \n at the end. like this: "DEV01\n" @user1557960

Mehrdad Pedramfar Over a year ago

change it to if eachenv.rstrip() in ["DEV01", "DEV02"] then update me here.

Mehrdad Pedramfar Over a year ago

Your welcome @user1557960. please consider this: stackoverflow.com/help/someone-answers

Lightness Races in Orbit · Accepted Answer · 2019-01-19 12:57:20Z

3

 if eachenv=="DEV01" or "DEV02":

Means, if either of the following:

eachenv is equal to "DEV01"
"DEV02"

Well, what about "DEV02"? It exists, so that option of the condition is going to be "truthy", so your if will always pass.

This is not how chained conditions work.

You meant:

if eachenv=="DEV01" or eachenv=="DEV02":

Now it's, if either of the following:

eachenv is equal to "DEV01"
eachenv is equal to "DEV02"

Yay!

answered Jan 19, 2019 at 12:57

Lightness Races in Orbit

387k77 gold badges672 silver badges1.1k bronze badges

Comments

user10902090 · Accepted Answer · 2019-01-19 13:07:56Z

2

In the line if eachenv=="DEV01" or "DEV02": the second condition is always true:

>>> if "DEV02":
...     print('hello')
... 
hello

This happens because the string "DEV02" is an object, therefore will be evaluated True.

@Lightness Races in Orbit gave the right way to write this if statement.

answered Jan 19, 2019 at 13:07

user10902090

Collectives™ on Stack Overflow

if-else inside for loop not working in python

3 Answers 3

4 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

4 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related