Pass variable from within PHP function [duplicate]

Question

I'd like to report how many files get deleted from a function that I'm running within php via a cron task.

Current codes is as follows:-

<?php

function deleteAll($dir) {
    $counter = 0;
    foreach(glob($dir . '/*') as $file) {
        if(is_dir($file)) {
            deleteAll($file); }
        else {
            if(is_file($file)){
// check if file older than 14 days
                if((time() - filemtime($file)) > (60 * 60 * 24 * 14)) {
                    $counter = $counter + 1;
                    unlink($file);
                } 
            }
        }
    }
}   

deleteAll("directory_name");

// Write to log file to confirm completed
$fp = fopen("logthis.txt", "a");
fwrite($fp, $counter." files deleted."."\n");
fclose($fp);

?>

That makes sense to me with a VBA background, but the counter returns null I think when written to my custom log file at the end. I presume there is some restriction on a shared hosting site of being able to declare the variable globally or similar?

Appreciate any help! It's not the end of world if I can't count the deleted files, but it would be nice to log the output in the format I've chosen.

Have the function return $counter. Right now you're dealing with a scope issue where the $counter used in your fwrite() call is not the same one as inside of your function. — Patrick Q
– Patrick Q, Commented Feb 4, 2019 at 15:56
Simply a scope issue. Take a look at this question and this question for details. — Dave
– Dave, Commented Feb 4, 2019 at 16:17

Martijn · Accepted Answer · 2019-02-05 13:29:32Z

0

This doesnt work due to scopes. In your example $counter only exists inside your function.

function deleteAll($dir):int {
    $counter = 0; // start with zero
    /* Some code here */
    if(is_dir($file)) {
        $counter += deleteAll($file); // also increase with the recursive amount
    }
    /* Some more code here */
    return $counter; // return the counter (at the end of the function
}

$filesRemoved = deleteAll("directory_name");

Alternatively, if you want to send back more info, eg 'totalCheck' etc, you can send back an array of info:

function deleteAll($dir):array {
    // All code here
    return [
        'counter' => $counter,
        'totalFiles' => $allFilesCount
    ];
}
$removalStats = deleteAll("directory_name");
echo $removalStats['counter'].'files removed, total: '.$removalStats['totalFiles'];

_{There are other solutions like 'pass-by-reference', but you dont want those.}

edited Feb 5, 2019 at 13:29

answered Feb 4, 2019 at 15:55

Martijn

16.2k4 gold badges39 silver badges73 bronze badges

Sign up to request clarification or add additional context in comments.

10 Comments

AbraCadaver Over a year ago

An alternate following some PHP functions: function deleteAll($dir, &$counter) then call as deleteAll("directory_name", $filesRemoved); But I would only use this if the function needs to return something else.

Martijn Over a year ago

And even then I'd change the function so I dont have to reference. IMO it's a code smell.

larkim Over a year ago

Thanks all - rapid respones! Think I've got my head around that, just a different concept to VBA on the basis of scope where you can't declare variables I suppose.

larkim Over a year ago

Hmmm. Still having issues with this. In my code, I've amended to call the funciton with "$filesRemoved = deleteAll("dir_name"); and added "return $counter; at the end of the "if" which tests the files age. But this bails out on me. If I add "return $counter" to the final sub clause of the if statement, no error is thrown but it just returns "0".

larkim Over a year ago

@Martijn So I've amended my code to add as per your first suggestion 'return $counter' but all I'm getting returned is the default value I'm setting '$counter' to at the beginning. I can output the incremental count within the if statement, but it isn't being sent at the end. I'm clearly doing something daft, but can't quite see it!!

|

Collectives™ on Stack Overflow

Pass variable from within PHP function [duplicate]

1 Answer 1

10 Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

10 Comments

Linked

Related