Parameters containing spaces not parsed correctly when used from string variable [duplicate]

Question

I've got some options for commands stored in variable. Unfortunately whenever there is a space bash treats that as variable separator despite string being in quotes.

I am aware, that proper way of doing it is using arrays in bash, but this situation I've encountered is based on legacy scripts which are deploying code on commit in git. Unfortunately I have to stay with string-in-variable solution, which was doing fine till there was a need to use space in one of arguments (take a look on example, there is --filter='- /logs/' parameter.

Example script:

#!/bin/bash

RSYNC_OPTS="-r --delete --exclude .env --filter='- /logs/' --links"
mkdir a b
rsync $RSYNC_OPTS a b

I got following error:

Unknown filter rule: `'-' rsync error: syntax or usage error (code 1) at exclude.c(927) [client=3.1.3]

As far as I understand, space after --filter='- acted like argument separator despite being used in single quotes.

Until now I tried:

quote mode for variable: ${RSYNC_OPTS@Q}
Escaping space or single quotes in RSYNC_OPTS variable
Changing single quotes with double ones

How to make bash interpret string in quote properly when sending it as string in variable? I hope that there will be solution that does not involve changing RSYNC_OPTS to something else than single string text variable.

KamilCuk · Accepted Answer · 2019-02-05 10:20:00Z

4

For such cases, bash arrays is the proper solution.

RSYNC_OPTS=(-r --delete --exclude .env --filter='- /logs/' --links)
rsync "${RSYNC_OPTS[@]}" a b

answered Feb 5, 2019 at 10:20

KamilCuk

146k8 gold badges85 silver badges154 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

DevilaN Over a year ago

Yeah. I know, but I am getting those options as string from: $(git config --get "deploy.${branch}.opts) as a string. Although thank you for your input.

nullPointer · Accepted Answer · 2019-02-05 10:19:03Z

0

Try with "$RSYNC_OPTS" (suppress globbing) and also use eval, eg :

eval rsync "$RSYNC_OPTS" a b

edited Feb 5, 2019 at 10:19

answered Feb 5, 2019 at 9:33

nullPointer

4,5891 gold badge20 silver badges31 bronze badges

3 Comments

DevilaN Over a year ago

Have you tried your answer? I've provided example script for testing purposes and it seems that "$RSYNC_OPTS" is treated as single argument to rsync and resulting in unknown option error

nullPointer Over a year ago

try with eval as per updated answer

pjh Over a year ago

See Why should eval be avoided in Bash, and what should I use instead?.

Collectives™ on Stack Overflow

Parameters containing spaces not parsed correctly when used from string variable [duplicate]

2 Answers 2

1 Comment

3 Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

3 Comments

Linked

Related