How to make an API call using async function?

Question

I'm new to node.js and I'm trying to migrate the backend of my company from python to node.js

Right now I created a node.js server using express. The route works fine. My company uses WooCommerce, and they have a node.js library. My code is this one:

const WooCommerceAPI = require("woocommerce-api");

class WooCommerceController {
  async getOrders(req, res) {
    const orders = await WooCommerce.get("orders", function(err, data, res) {
      return res;
    });
    return res.json(orders);
  }
}

module.exports = new WooCommerceController();

I know that

WooCommerce.get("orders", function(err, data, res) {
      console.log(res);
    });

works, because if I execute this function it returns the list of orders of my company, however if I try to put it inside this async await, it returns the status of the WooCommerce API, not the response of the API.

What am I doing wrong?

Can you share your code with async await, that is not working? — Shriram Manoharan
– Shriram Manoharan, Commented Apr 15, 2019 at 2:28
WooCommerce.get() would need to return a promise to use await. It is using a callback not promise — charlietfl
– charlietfl, Commented Apr 15, 2019 at 2:28
I believe WooCommerce.getAsync serves that purpose, let me check — RichS
– RichS, Commented Apr 15, 2019 at 2:33

FZs · Accepted Answer · 2019-04-15 03:26:42Z

1

WooCommerce.get works with a callback, while await only works with functions that return a Promise. So either you need to create a promise yourself, and manually resolve it in the callback, or you can use util.promisify to automatically convert the callback-function (with an (err, value) callback parameters) to a Promise-style function.

const wooGetPromise = util.promisify(WooCommerce.get);
...
const orders = await wooGetPromise("orders");
...

EDIT: Thanks to RichS for looking up the API: my wooGetPromise already exists as WooCommerce.getAsync.

The options for using that function are:

With then:

    WooCommerce.getAsync('orders').then(function(result) {
       return JSON.parse(result.toJSON().body);
    });

With await (only in async function):

    var result = await WooCommerce.getAsync('orders');
    var json = JSON.parse(result.toJSON().body);

edited Apr 15, 2019 at 3:26

FZs

18.8k13 gold badges47 silver badges56 bronze badges

answered Apr 15, 2019 at 2:28

Amadan

200k23 gold badges253 silver badges321 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

Ele Over a year ago

await only works with functions that return a Promise?

RichS Over a year ago

See also: npmjs.com/package/woocommerce-api#promified-methods (the npm repo mispelled "promisifed"). I think the WooCommerce.getAsync() method could be used... (Yeah, the library uses bluebird under the hood...)

Amadan Over a year ago

@Ele Good point. await only usefully works with functions that return a Promise.

Otavio Bonder Over a year ago

Thank you guys! This promified methods weren't in their documentation. I had a look at the npm repo and it worked! Thank you so much for the ultra fast solution!

Amadan Over a year ago

@Ele: That too, but that's not what I'm saying. You are talking about the function that surrounds await (which is off-topic here). I'm talking about the value that follows the await keyword (which is relevant here, because WooCommerce.get(...) doesn't return a promise, and is thus useless waste of cycles to await it).

|

naveen ashok · Accepted Answer · 2019-04-15 03:37:00Z

0

hello mate await usually resolves a promise so the function that is being called after the await key word should be a function that returns a promise or an asyn function which by default returns a promise.

Async function

WooCommerce.get("orders", async function(err, data, res) {
      return res;
});

Or a function that returns a promise

WooCommerce.get("orders", function(err, data, res) {
  return new Promise(function(resolve, reject){
   err ? reject(err) : resolve(res);
  }
});

answered Apr 15, 2019 at 3:37

naveen ashok

3312 silver badges17 bronze badges

Collectives™ on Stack Overflow

How to make an API call using async function?

2 Answers 2

7 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

7 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related