How make multiple if conditions with regex in shell script

Question

I have 2 values, project and tag. I need check if them are empty/null and if project has only characters (except '-') and if tag has only numbers (expect '.').

User actually invert the order of them, first need be project and after tag.

I try invert the regex of $project and $tag if user wrong the order... But nothing happens, no errors and code continue.

if [ -z $project ] || 
   [ -z $tag ] || 
   [[ $project =~ '/^[0-9]+(\.[0-9]+)*$/' ]] || 
   [[ $tag =~ '/^[A-Za-z]+(\-[A-Za-z]+)*$/' ]] ; then
  echo Project or tag wrong, please try again. &&
  echo Example: file.sh project-test 1.99.2
fi

This code no give me errors, but also not do what I need. What I'm doing wrong here?

---- update with answer

My syntax was wrong, now it's working fine (without quotes).

if [[ $project =~ ^[0-9]+(\.[0-9]+)*$ ]] && 
   [[ $tag =~ ^[A-Za-z]+(\-[A-Za-z]+)*$ ]] ; then
  echo Correct
else
  echo Project or tag wrong, please try again. &&
  echo Example: file.sh project-test 1.99.2
fi

James Li · Accepted Answer · 2019-09-06 16:11:36Z

1

only let it pass when everything all right
grep -cP uses perl compatible regex, and print the number of matched lines
combined with echo ,count limited to 0 or 1 only
i functioned them and replace 4 "not" condition with 2 "yes" condition

#!/bin/bash
function check_arg() {
project=$1
tag=$2
if [ `echo $project|grep -cP '^[-a-zA-z]+$'`  -eq 1 ] &&
   [ `echo $tag|grep -cP '^[\.0-9]+$'`  -eq 1 ] ;
   then
   echo all good $project $tag
else
    echo Example : file.sh project-test 1.99.2
fi

}

check_arg project-test 99.2
check_arg 1.99.2  project-test

output

all good project-test 99.2
Example : file.sh project-test 1.99.2

answered Sep 6, 2019 at 16:11

James Li

5043 silver badges7 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

dfop02 Over a year ago

I tried and get the error [: -eq: unary operator expected.

James Li Over a year ago

the error is telling nothing appears between [ and -eq , which i should have protected with quote and counting. could you update your post with your exact code piece

James Li Over a year ago

you put the ending ` at the wrong place, which should go right after single quote,

dfop02 Over a year ago

I try it and get the same error, but I also find an other way that working fine, thanks you.

James Li Over a year ago

good luck. quotes can easily messed up and more than one way to fix

Collectives™ on Stack Overflow

How make multiple if conditions with regex in shell script

1 Answer 1

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related