javascript for onClick not executing?

Question

ok maybe i must put all my code:

<?php
include('header_application.php');
$obj_clean->check_user();
$limit = 10;
if(!isset($_GET['page']))
  $page = 1;
else
$page = $_GET['page'];

$from = (($page * $limit) - $limit);
$msg = "";
if (isset($_GET['unblock']))
{
  $code = $obj_clean->unblockUser($_GET['unblock'],$_GET['code']);
  if ($code == "error")
  {
     $msg = "Could not delete message!";
  }
  else
  {
    $msg = "You have unblocked ".$code;
  }
}

//Get dynamic data required for this page from the database
$users = $obj_clean->getContacts($_SESSION['user_id'], $from, $limit);
$rows = $obj_clean->getContactsCount($_SESSION['user_id']);
include ("header.php");
?>
<div class="innerContainer">
<head>
<script type="text/JavaScript">
function yesnolist(val)
{
 var e = confirm('Do you want to send a free chat request?');
 if (e == true)
 {
    window.location.href = "http://www-rainbowcode-mobi/confirmfreechat.php";
    //window.location('http://www-rainbowcode-mobi/confirmfreechat.php');
    return true;
 }
  else
    return false;
 }     
</script>  
</head>
<span class="headings2">CONTACTS</span>
<?php if (isset($msg) && !empty($msg)) echo "<br/><font color='red'>".$msg."</font>"; ?>
<br/><br/>
<?php
if (count($users) > 0)
{
    echo "<table width='100%' cellpadding='0' cellspacing='0' border='0'>";
    foreach ($users as $user)
    {
        //Breaks the unique code into 3 parts so that the numeric part can be a different colour
        $codeLength = strlen($user['unique_code']);
        $firstPartLength = $codeLength - 5;
        $uniqueCode3 = substr($user['unique_code'], -2);
        $uniqueCode2 = substr($user['unique_code'], -5, 3);
        $uniqueCode1 = substr($user['unique_code'], 0, $firstPartLength);
        echo '<tr>';
        echo '<td>';
        echo '<a class="charcoal_link" style="line-height: 20px;" href="'.ADDRESS.'view_profile.php?id='.$user['profile_id_contact'].'">'.$uniqueCode1.'<span class="pink_text">'.$uniqueCode2.'</span>'.$uniqueCode3.'</a>';
        $requestor_id = $_SESSION['user_id'];
        $profile_id = $user['profile_id_contact'];
        $rel1 = $obj_clean->hasRelation($requestor_id,$profile_id);
        $rel2 = $obj_clean->hasRelation($profile_id,$requestor_id);
        if($rel1 && $rel2) 
        {
          echo "&nbsp;&nbsp;";
          //echo '<a href="confirmfreechat.php?id='.$profile_id.'" onClick="yesnolist()">Free Chat</a>';
          echo '<a href="#" onClick="yesnolist(); return false;">Free Chat</a>';
        }
        echo "</td>";
        echo "</tr>";
    }
    echo "</table>";
}
else
{
    echo "You have no contacts yet";
}
?>
</div>
<?php include("footer.php"); ?>

hope this will help better

What errors are you getting in your error console? Why do you have a div element before head? That is not valid. Where does your body tag begin? — Pekka
– Pekka, Commented May 4, 2011 at 9:40
Don't know if this is just a in issue of the above example and your actual code is correct, but the last line should be inside a <?php ?> block. Moreover, I quote Pekka: tell us what happens in the error console and write a cleaner test case. — gd1
– gd1, Commented May 4, 2011 at 9:41
@Pekka: body element, sir, body element. Tag is not an element. Or is it? — Marcel Korpel
– Marcel Korpel, Commented May 4, 2011 at 9:44
@HelloiseSmit: Please format it correctly so that other people can read it. — Felix Kling
– Felix Kling, Commented May 4, 2011 at 10:40

Nathan · Accepted Answer · 2011-05-04 09:42:54Z

3

<a href="" onClick="yesnolist()">Free Chat</a>

should be:

<a href="#" onClick="yesnolist(); return false;">Free Chat</a>

answered May 4, 2011 at 9:42

Nathan

6,2244 gold badges38 silver badges66 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Nathan Over a year ago

(you want to return false regardless of the outcome of the function call so that the click event is cancelled and therefore the page isn't left before your js function is called)

ariel · Accepted Answer · 2011-05-04 09:43:42Z

0

try this:

function yesnolist()
{
    if (confirm('Do you want to send a free chat request?'))
        window.location = "http://www-rainbowcode-mobi/confirmfreechat.php";
}

. . .

<a href="#" onClick="yesnolist()">

answered May 4, 2011 at 9:43

ariel

16.2k13 gold badges65 silver badges75 bronze badges

Comments

trickwallett · Accepted Answer · 2011-05-04 09:46:30Z

0

I'd assume changing the URLs to valid domains might help things, so try:

window.location.href = "http://www.rainbowcode.mobi/confirmfreechat.php";
window.location('http://www.rainbowcode.mobi/confirmfreechat.php');

answered May 4, 2011 at 9:46

trickwallett

2,45817 silver badges16 bronze badges

Comments

Cosmin · Accepted Answer · 2011-12-15 14:28:17Z

0

function yesnolist()
{
  var e = confirm('Do you want to send a free chat request?');

  if (e == true)
  {
    window.location = "http://www-rainbowcode-mobi/confirmfreechat.php";
    return true;
  }
  else
    return false;
}

and

<label onClick="return yesnolist();">Free Chat</a>

You can not pass onclick event on (a href="") tag because href part redirects the page and after that the javascript redirect part is called.

Or

(a href="#" onclick="return yesnolist();")Free Chat(/a)

edited Dec 15, 2011 at 14:28

Cosmin

21.5k5 gold badges48 silver badges61 bronze badges

answered May 4, 2011 at 10:18

Jimesh Gajera

6122 gold badges11 silver badges32 bronze badges

Collectives™ on Stack Overflow

javascript for onClick not executing?

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related