How to make input verification in a separate function? the program should take the input sequence 1 and 0

Question

def check(SEQ):
    for i in SEQ:
        isinstance(i, int)
    if not (set(SEQ) == {0, 1} or set(SEQ) == {1} or set(SEQ) == {0}):
        return False
    else:
        return True


def main():
    SEQ = [i for i in input("Enter the sequence 0 and 1   ").split()]
    while not check(SEQ):
        print("Invalid values ")
        SEQ = [i for i in input("Enter the sequence 0 and 1 ").split()]


if __name__ == '__main__':
    main()

You already have a function called check, that checks the user input. But it can be massively simplified. In the first step do SEQ = list(map(lambda x: int(x), SEQ.split)). Then check if all(map(lambda x: x==1 or x==0, SEQ)) — Tekno
– Tekno, Commented Nov 14, 2019 at 12:05
Instead of three cases, why not check if the input is a subset of {0,1}? Also -- you don't need if ... else to convert a boolean into a boolean. Just return the comparison itself. Those 4 lines in the function can be replaced by the 1 line return set(SEQ) <= {0,1} (fine print: this comparison would validate the empty string, but your original code would not. Since the empty string is a binary sequence, albeit a trivial one, this is a feature of my suggestion rather than a bug). — John Coleman
– John Coleman, Commented Nov 14, 2019 at 12:07
As far as the edit goes -- I don't see how an edit which deletes OP's code from a question can be valid. I thus rolled it back. — John Coleman
– John Coleman, Commented Nov 14, 2019 at 12:15

Tekno · Accepted Answer · 2019-11-14 12:38:23Z

1

Like this:

def check(value):
    return all(map(lambda x: x=='1' or x=='0', value.split()))

edited Nov 14, 2019 at 12:38

answered Nov 14, 2019 at 12:15

Tekno

3142 silver badges9 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

John Coleman Over a year ago

Wouldn't you need to either convert to int or use '0', '1'?

Tekno Over a year ago

Sorry. Forgot about the type. Changed to string.

Collectives™ on Stack Overflow

How to make input verification in a separate function? the program should take the input sequence 1 and 0

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related