Laravel add error message to validator in custom form request

Question

I have a custom form request where I do some extra validation logic and I want to add an error if my logic fails but I get this error:

Call to a member function errors() on null

Here is my custom Request:

if (!empty($this->get('new_password')) && !empty($this->get('current_password'))) {
    if (
        !Auth::attempt([
            'email' => $this->get('email'),
            'password' => $this->get('current_password'),
            'status' => 'pending'
        ])
    ) {
        $this->validator->errors()->add('current_password', 'Something is wrong with this field!');
    }
}

return [                    
    'first_name' => 'required|min:1|max:190',        
];

EDIT complete class

class ProfileRequest extends FormRequest
{
    public function authorize()
    {
        return Auth::check();
    }

    public function rules()
    {
        if (!empty($this->get('new_password')) && !empty($this->get('current_password'))) {
            if (
                !Auth::attempt([
                'email' => $this->get('email'),
                'password' => $this->get('current_password'),
                'status' => 'pending'
                ])
            ) {
                $this->validator->getMessageBag()->add('current_password', 'Something is wrong with this field!');
            }
        }

        return [
            'first_name'       => 'required|min:1|max:190',
        ];
    }
}

Call to a member function errors() on null means $this->validator is null. Please check where you have initialised $this->validator — Sehdev
– Sehdev, Commented Feb 18, 2020 at 9:44
@Sehdev it comes from the FormRequest that extens my custom form request laravel.com/docs/5.8/validation#creating-form-requests — user3652775
– user3652775, Commented Feb 18, 2020 at 9:45

Amit Senjaliya · Accepted Answer · 2020-02-18 09:56:58Z

6

I think you need to add the hook withValidator as laravel doc suggested.

public function withValidator($validator)
{
    $validator->after(function ($validator) {
        if ($this->somethingElseIsInvalid()) {
            $validator->errors()->add('field', 'Something is wrong with this field!');
        }
    });
}

answered Feb 18, 2020 at 9:56

Amit Senjaliya

2,9651 gold badge12 silver badges24 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

user3652775 Over a year ago

where do I call this withValidator() function then?

Amit Senjaliya Over a year ago

@user3652775 In the form request file.

user3652775 Over a year ago

it doesnt make sense to me I am sorry

Amit Senjaliya Over a year ago

@user3652775 Please read this doc for more understand: laravel.com/docs/5.8/validation#form-request-validation

user3652775 Over a year ago

I don't see or read where I need to call this function: withValidator($validator) It just says I can make it. Okay I put it in my ProfileRequest but it's never called?

|

Collectives™ on Stack Overflow

Laravel add error message to validator in custom form request

EDIT complete class

1 Answer 1

6 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

EDIT complete class

1 Answer 1

6 Comments

Your Answer

Sign up or log in

Post as a guest

Related