ForEach Loop Iterates Twice Instead Of Once - Powershell

Question

Once again I have broken a foreach loop and cannot figure out why. It appears to iterate twice instead of once for some of the accounts. I think I have my {} in the correct format but apparently not. Can anyone help me find what I'm missing?

Relevant Code:

foreach ($OU in $OUs) {

    # Search for User and/or Computer Objects inactive for XX days.  Disable object if not in DoNotDisable Security Groups
    $days = $days + "D"
    $accounts = Search-ADAccount -SearchBase $OU.DistinguishedName -AccountInactive -TimeSpan ([timespan]7D) @scope
    foreach($account in $accounts){
        If ($noDisable -notcontains $account.Name) {
            Write-Host $account
    #        #Disable-ADAccount -Identity $account.DistinguishedName -Verbose $whatIf | Export-Csv $logFile
       }
    }
}

Output: Each computer account is listed twice except the last 2.

None of your output lines are exact duplicates, so I don't understand why you think your code is running twice. Can you elaborate? — Matthew
– Matthew, Commented Feb 19, 2020 at 15:25
@Matthew Please see the output screenshot. Each computer account is listed twice instead of once except for the last 2. — poisedforflight
– poisedforflight, Commented Feb 19, 2020 at 15:33
@poisedforlight I would try loading the script in PowerShell ISE and stepping through the code one line at a time. This will certainly show you what your code is doing and why. — Matthew
– Matthew, Commented Feb 19, 2020 at 15:37
Add -SearchScope OneLevel to the Search-ADAccount command — Mathias R. Jessen
– Mathias R. Jessen, Commented Feb 19, 2020 at 16:00

Mathias R. Jessen · Accepted Answer · 2020-02-19 16:02:24Z

3

If your directory tree looks like this:

NC root
 |- TopLevelOU
     |- SubOU
     |   |- Computer1
     |   |- Computer2
     |- Computer3
     |- Computer4

... and you start by querying for all OUs, and then search (recursively) through each one, you're going to get every object under SubOU twice - once from searching through the TopLevelOU, and once more from searching directly against SubOU.

Add -SearchScope OneLevel to your Search-ADAccount invocation if you want to contain each search to the immediate children of the target OU:

$accounts = Search-ADAccount -SearchBase $OU.DistinguishedName -SearchScope OneLevel -AccountInactive -TimeSpan ([timespan]7D) @scope

answered Feb 19, 2020 at 16:02

Mathias R. Jessen

178k13 gold badges175 silver badges234 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

poisedforflight Over a year ago

Your explanation is very much appreciated. That got me what I needed and more importantly I now understand why it wasn't working

Collectives™ on Stack Overflow

ForEach Loop Iterates Twice Instead Of Once - Powershell

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related