Problem inserting row into oracle

Question

Any idea why this doesn't work?

The name of the table is TESTTABLE with just one column called TEST_COLUMN which is the primary key. I'm sure it is something dumb, but thought i'd ask. I'm already connected to the database so i didn't worry about providing that code

Statement statement = connection.createStatement();
String test = "test";
statement.executeUpdate("INSERT INTO TESTTABLE (TEST_COLUMN) VALUES (" + test + ")");

gives me this error

ORA-00984: column not allowed here

D'Arcy Rittich · Accepted Answer · 2011-05-17 19:51:55Z

5

I am assuming that is a varchar column, so try:

statement.executeUpdate("INSERT INTO TESTTABLE (TEST_COLUMN) VALUES ('" + test + "')");

Note the single quotes around the data.

answered May 17, 2011 at 19:51

D'Arcy Rittich

172k41 gold badges298 silver badges287 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

pickypg Over a year ago

The single quotes definitely nailed the problem on the head. @auwall You should look into using PreparedStatementsto help avoid SQL injection.

DCookie Over a year ago

@auwall: Character data constants in Oracle must be enclosed in single quotes, which is what you're feeding Oracle with this statement. Generally speaking, building dynamic statements this way in Oracle is a Bad Idea, both for the reason @pickypg states as well as performance issues. You should use bind variables whenever possible.

auwall Over a year ago

ok i will look into that now. question though. I obtained a statement from connection.createStatement(); How do i obtain a PreparedStatement?

Olaf Over a year ago

@auwall: From the same conneciton. Just call prepareStatement().

auwall Over a year ago

Thank, until 20 minutes ago i had never used anything of this sort and now it's working perfect.

Collectives™ on Stack Overflow

Problem inserting row into oracle

1 Answer 1

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related