External JS not working when called from PHP created HTML

Question

I have a PHP script that creates HTML by calling PHP class that I have created. The class creates all the HTML tags one of which is a tag that loads an external JS file. When I try to access the functions from said file nothing happens. Any Ideas?

index page:

function main(){
    $content = "Heres some text for you";

    $page = new Page($title="MyTitle", $script="external.js", $content=$content)
    echo $page->toString();
}

function __autoload($className){
    require_once $className . '.class.php';
}

class page:

    //class constructor
    function __construct($title='untitled', $script='', $content='Default Page class page'){
    $this->title = $title;
    $this->script = $script;
    $this->stylesheet = $stylesheet;
    $this->content = $content;
    // $this->currentUser = $currentUser;
    }

    // creates tag structure for HTML pages
    function toString(){
    return <<<END
            <!DOCTYPE html>
            <html xmlns="http://www.w3.org/1999/xhtml">
            <head>
            <meta http-equiv="content-type" content="text/html; charset=utf-8" />
            <script type="text/javascript" src="jquery.js"></script>
            // Heres the link to the external JS file
            <script type="text/javascript" src="$this->script"></script>

            <script type="text/javascript">
                 test();
            </script>
            <title>$this->title</title>
            <link type="text/css" rel="stylesheet" href="$this->stylesheet" />
            </head>
            <body>
        $this->content
        <p id='content'>page content</p>
            </body>
            </html>
END;
    }// end toString function

} // end class Page
?>

External JS:

function test(){
    alert("ext. JS test works");
}

What does the generated html look like when you look at the source in your browser? — jeroen
– jeroen, Commented May 19, 2011 at 19:29

jeroen · Accepted Answer · 2011-05-19 18:53:23Z

2

You cannot have any spaces before the ending identifier of your heredoc:

        END;

should be:

END;

answered May 19, 2011 at 18:53

jeroen

91.8k22 gold badges118 silver badges132 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user761572 Over a year ago

Sorry, this was my first post and the code transfer was messy. Rest assured that there were no spaces before the ending identifier in the original. Thanks though

score 0 · Accepted Answer · 2011-05-19 19:10:04Z

0

I would also check to make sure that the path to your external.js file is correct. Are any of the other things working? Like the title or css? You also are not passing $stylesheet into your __construct anywhere which produces an error trying to set $this->stylesheet, maybe the whole script is failing to load because of that?

edited May 19, 2011 at 19:10

answered May 19, 2011 at 19:04

Corey

1 Comment

user761572 Over a year ago

sorry forgot to delete that. That was left over from deletes i made for the post

JFitzDela · Accepted Answer · 2011-05-19 19:23:46Z

0

Don't see anything that stands out....

Are you sure the JS file is accessible in the same directory as your script (may want to apply an absolute or relative path if necessary)?

You might also, since you have jquery (assuming it's loaded), try putting the call to test(); in an "on ready" block, like so:

$(document).ready(function () {
    test();
});

Other than that, I'd use your given browsers debugging tools to see if you can glean anything useful (like the script not even being loaded as a resource).

Good luck!

edited May 19, 2011 at 19:23

answered May 19, 2011 at 19:12

JFitzDela

716 bronze badges

4 Comments

user761572 Over a year ago

I have the function call in a ready block but I doesn't seem to make a difference. Firebug isn't showing the external js file (only the jquery one) I think it may have something to do with me setting the source of the script to $this->script not sure why though

JFitzDela Over a year ago

Try just changing $this->script to external.js -- if it works, it IS a problem with the $this notation....

JFitzDela Over a year ago

Even simpler would be to just view the source and make sure $this->script is translating correctly to external.js If it is, I'd triple-check the location of the external.js file...

user761572 Over a year ago

AND THE ANSWER IS .... i had one too many closing braces on an if statement in one of the functions in the external JS file. Sorry to have wasted everyones time

Collectives™ on Stack Overflow

External JS not working when called from PHP created HTML

3 Answers 3

1 Comment

1 Comment

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

1 Comment

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related