C# string.split on readline not producing expected array length

Question

Hi guys just carrying on working on my first app, done mainly to learn and nothing else. I want the user to be able to type in 2d6+4 OR 2d6, you should be able to substitute those numbers for any number. I'm getting errors parsing the information and I think it has something to do with the array containing more or less values than I anticipated, or it for some reason left the delimiter in. typing 2d6+4 or 2d6 +4 works fine, 2d6 however does not, which is what I thought the if statement should guard against. Any ideas?

        Console.WriteLine("Please type the roll you would like to perform, for example - 2d6+4");
        var rollLine = Console.ReadLine();
        var diceLine = rollLine.Split(new Char[] { 'd', '+' }, StringSplitOptions.RemoveEmptyEntries);
        diceCount = int.Parse(diceLine[0]);
        diceType = int.Parse(diceLine[1]);
        if (rollLine.Length > 2)
        {
        bonus = int.Parse(diceLine[2]);
        }
        else
        {
            bonus = 0;
        }

Sarah Shelby · Accepted Answer · 2020-04-13 21:38:29Z

2

It looks like you are just using the wrong variable for the length comparison. You are comparing the length of the string, not the length of the split array. It should be:

if (diceLine.Length > 2)

answered Apr 13, 2020 at 21:38

Sarah Shelby

4611 gold badge3 silver badges13 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Henry Puspurs Over a year ago

Thanks it was just using the wrong variable. It was the array length I wanted to check for some reason I thought rollLine was the array after parsing when its plainly clear its not. Thank you!

user2316116 · Accepted Answer · 2020-04-13 21:22:15Z

1

When user entered "2d6", the string length is 3, i.e. following rule is true

if (rollLine.Length > 2)

However, as per your logic you will get array of 2 items in the diceLine, i.e. diceLine[0] and diceLine[1] but after condition with length you call diceLine[2] that does not exist.

I.e. either change condition to

if (rollLine.Length == 5) // 2d6+4

or check for the length of the array

if (diceLine.Length > 2)

answered Apr 13, 2020 at 21:22

user2316116

6,8221 gold badge24 silver badges36 bronze badges

2 Comments

Deolus Over a year ago

It's probably preferable to check the length of the array as in this example in case you want to do 2d12 etc. at some point.

user2316116 Over a year ago

dice is 1 to 6, but I agree it depends on the need

Steve · Accepted Answer · 2020-04-13 21:22:50Z

0

You want your IF to check if the rollLine length is greater than 3, not 2. As the smallest thing you'll type in is, for example, 2d6, you want to check for the bonus only when the rollLine is more than 3 characters.

if (rollLine.Length > 3)
{
    bonus = int.Parse(diceLine[2]);
}

answered Apr 13, 2020 at 21:22

Steve

1,9535 gold badges23 silver badges33 bronze badges

Collectives™ on Stack Overflow

C# string.split on readline not producing expected array length

3 Answers 3

1 Comment

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related