A nested for loop will always run n*n2 times.
In your case, there is no need to nest the loop, you can just do it like this:
#bin/bash
whatever=("P02183606" "PID" "P02183608" "PID2");
for((i = 0; i<${#whatever[@]}; i=i+2));
do
curl -i -H "Authorization:Token dont share it ffs" "Content-type: application/json" -X GET "http://indiafirstlife.com//onlineInsurance-rest/uploadDocument/uploadDocumentsOmniMannualPush?applicationRefNo=${whatever[i]}&applicationFormId=${whatever[i+1]}"
echo "Accessing: http://indiafirstlife.com/onlineInsurance-rest/uploadDocument/uploadDocumentsOmniMannualPush?applicationRefNo=${whatever[i]}&applicationFormId=${whatever[i+1]}"
done
Output:
Accessing: http://indiafirstlife.com/onlineInsurance-rest/uploadDocument/uploadDocumentsOmniMannualPush?applicationRefNo=P02183606&applicationFormId=PID
Accessing: http://indiafirstlife.com/onlineInsurance-rest/uploadDocument/uploadDocumentsOmniMannualPush?applicationRefNo=P02183608&applicationFormId=PID2