Update value in array based on same id in angular

Question

I have this array

const buildings = [
  { id: 111, status: false, image: 'Test1' },
  { id: 334, status: true, image: 'Test4' },
  { id: 243, status: false, image: 'Test7' },
  { id: 654, status: false, image: 'Test9' },
  { id: 222, status: true, image: 'Test8' }
];

What I need is to update same value based on new porperti

cons newBuilding = { id: 111, status: true, image: 'Test1' };

I need a function that will handle like that like this

    mergeSelectedBuildings(building) {
    if (buildings.length >= 0) {
      buildings.push(building);
    } else {
      buildings.map((buildingValue, i) => {
        if (buildingValue.id === building.id) {
          this.buildings[i].status = building.status;
          this.buildings[i].image = building.image;
        } else {
          this.buildings.push(building);
        }
      });
    }
  }

The problem is that this does not work as expected, it always add new and new value it does not update:(

Kurt Hamilton · Accepted Answer · 2020-05-06 09:55:31Z

3

I wouldn't use the map array function like this. Instead, try to find the item and update that object. If the item isn't found, push the building to the array.

mergeSelectedBuildings(building) {
  const existing = this.selectedBuildings.find(x => x.id === building.id);
  if (existing) {
    existing.status = building.status;
    existing.image = building.image;
  } else {
    this.selectedBuildings.push(building);
  }
}

answered May 6, 2020 at 9:55

Kurt Hamilton

13.7k1 gold badge28 silver badges42 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Miomir Dancevic Over a year ago

const currentBuilding = buildings.find(building => building.id === newBuilding.id); will return undefined

Damian Plewa · Accepted Answer · 2020-05-06 10:16:34Z

1

You need to find object from array that is equal to id, then if it's not existing in array, you need to push it, else you need to update values of existing building object

mergeSelectedBuildings(newBuilding) {
  const currentBuilding = buildings.find(building => building.id === newBuilding.id);
  if (!currentBuilding) {
    buildings.push(newBuilding);
    return;
  }
  currentBuilding.status = newBuilding.status;
  currentBuilding.image = newBuilding.image;
}

Example of usage:

console.log(buildings);

mergeSelectedBuildings(newBuilding);

console.log(buildings);

output:

[
  { id: 111, status: false, image: 'Test1' },
  { id: 334, status: true, image: 'Test4' },
  { id: 243, status: false, image: 'Test7' },
  { id: 654, status: false, image: 'Test9' },
  { id: 222, status: true, image: 'Test8' }
]
[
  { id: 111, status: true, image: 'Test1' },
  { id: 334, status: true, image: 'Test4' },
  { id: 243, status: false, image: 'Test7' },
  { id: 654, status: false, image: 'Test9' },
  { id: 222, status: true, image: 'Test8' }
]

edited May 6, 2020 at 10:16

answered May 6, 2020 at 9:56

Damian Plewa

1,2138 silver badges13 bronze badges

2 Comments

Miomir Dancevic Over a year ago

const currentBuilding = buildings.find(building => building.id === newBuilding.id); Will return undefined

Damian Plewa Over a year ago

Only if there is no building with specified id, then if (!currentBuilding) will be executed

Shlok Nangia · Accepted Answer · 2020-05-06 09:53:06Z

0

please try this snippet

const buildings = [
  { id: 111, status: false, image: 'Test1' },
  { id: 334, status: true, image: 'Test4' },
  { id: 243, status: false, image: 'Test7' },
  { id: 654, status: false, image: 'Test9' },
  { id: 222, status: true, image: 'Test8' }
];


const newBuilding = { id: 111, status: true, image: 'Test1' };

var b = buildings.find(e => e.id == newBuilding.id)
b.image = newBuilding.image
b.status = newBuilding.status
console.log(buildings)

this finds the building by id property

answered May 6, 2020 at 9:53

Shlok Nangia

2,3773 gold badges19 silver badges25 bronze badges

Comments

Ron Rofe · Accepted Answer · 2020-05-06 09:59:15Z

0

Try using this function:

const buildings = [
   ...
];

const update = (item: { id: number, status: boolean, image: string }): void {
   const index = buildings.findByIndex(current => current.id === item.id);
   if(index !== -1) {
      buildings[index] = item;
   }
}

answered May 6, 2020 at 9:59

Ron Rofe

7972 gold badges10 silver badges26 bronze badges

Collectives™ on Stack Overflow

Update value in array based on same id in angular

4 Answers 4

1 Comment

2 Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related