Shell script - Bad substitution Error while running script with sh

Question

I am trying to loop inside a directory and rename the file name with space. But i m getting the bad substitution error while running it with sh test.sh

#!/bin/bash
for f in /home/admin1/abc/*.kmz
do
mv "$f" "${f// /_}"
#rm $i
done

Since i need to configure in crontab i may need to run it with sh command not with ./

Glad I could help. Made my comment an answer you can accept :) — AKX
– AKX, Commented May 11, 2020 at 6:13

AKX · Accepted Answer · 2020-05-11 06:12:47Z

5

To make my comment an answer:

You're running with sh, but your script declares it's a bash script. On many systems sh is not bash, but a lighter shell that doesn't support all bashisms.

Either

run with bash test.sh, or
mark the file chmod u+x and run ./test.sh to use the shebang line.

answered May 11, 2020 at 6:12

AKX

171k16 gold badges148 silver badges230 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

yacc · Accepted Answer · 2020-05-09 13:27:30Z

2

Bourne Shell sh doesn't support this type of substitution. You could run this script:

for f in /home/admin1/abc/*.kmz
do
  mv "$f" `echo "$f" |tr ' ' _`
done

answered May 9, 2020 at 13:27

yacc

3,4169 gold badges25 silver badges42 bronze badges

Collectives™ on Stack Overflow

Shell script - Bad substitution Error while running script with sh

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related