Javascript Function Accepting PHP Variables

Question

I'm drawing a complete blank why this isn't working. I can do it with one variable passing through, but not two. When I use actually numbers like getnt(1,2) it works. It's just not working with two PHP variables.

  <script type="text/javascript">
  function getnt(nid,pnid) {
      window.location = "nt.php?nid=" + nid + "&pnid=" + pnid;
  }
  </script>
  <body>  
  <?php
    echo "<a href='#' onclick='getnt($nid,$pnid)'>VIEW</a>";
  ?>
  </body>

I can make the code work with echo "<a href='nt.php?nid=$nid&pnid=$pnid'>VIEW</a>";, but that's no good if I want to add in alerts and javascript commands.

did you view the source code? looks fine to me.... although i'd generate the whole URL in PHP and put it in the href. — mpen
– mpen, Commented Jun 1, 2011 at 2:02
You would need to setup a demo page so we can see the generated code. But I agree with Mark, looks okay. — Adam Heath
– Adam Heath, Commented Jun 1, 2011 at 2:05
Check the generated code. What does $nid and $pnid contain? — Felix Kling
– Felix Kling, Commented Jun 1, 2011 at 2:05

AjayR · Accepted Answer · 2011-06-01 02:09:05Z

2

If the ID and pnID are strings, enclose them with brackets like this.

<body>  
  <?php
    echo "<a href='#' onclick=\"getnt('$nid','$pnid')\">VIEW</a>";
  ?>
  </body>

If still not working, You can debug your code

View the source code in browser, make sure it generates correctly.
Put some alert messages in the javascript function. Install Firebug if you have Firefox or see
Javaascript console if you get any javascript errors.

answered Jun 1, 2011 at 2:09

AjayR

4,1894 gold badges49 silver badges81 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

yanike Over a year ago

Thanks that worked. I see now that when using onclick I need to use onclick=\"..whatever..\" for now on within echo. It causes problems when I don't.

Petah · Accepted Answer · 2011-06-01 02:06:56Z

2

You could always try:

<script type="text/javascript">
    function getnt(nid,pnid) {
        window.location = "nt.php?nid=" + nid + "&pnid=" + pnid;
    }
</script>
<body>  
    <a href="#" onclick="getnt(<?php echo $nid; ?>,<?php echo $pnid; ?>)">VIEW</a>
</body>

answered Jun 1, 2011 at 2:06

Petah

46.2k30 gold badges161 silver badges217 bronze badges

3 Comments

Felix Kling Over a year ago

This is certainly better, but should not make a difference in this case.

user743234 Over a year ago

@Felix: since there is no perfectly robust way of doing things, and when something that should be true being false, we need to look at different ways and approaches to deal with it, even though they look silly. Note that this website is for providing all the possibilities to the problems. Have you ever experienced a silly problem? And the answer that sounds silly can fix it. Upvoted again (:

Felix Kling Over a year ago

@Being: I totally agree with you. FWIW, I did not down vote. I just wanted to point out that there is no difference regarding the output between this code and the OP's code. So although being better, it does not solve the problem...

Phil · Accepted Answer · 2011-06-01 02:12:46Z

0

Your question is probably best answered by looking at the rendered HTML source.

In any case, here's how I'd do it using graceful degradation

<script type="text/javascript">
function getnt(element) {
    var href = element.href;
    var nid = element.getAttribute("data-nid");
    var pnid = element.getAttribute("data-pnid");
    return true;
}
</script>
<p><a href="nt.php?nid=<?php echo $nid ?>&amp;pnid=<?php echo $pnid ?>"
      data-nid="<?php echo $nid ?>"
      data-pnid="<?php echo $pnid ?>"
      onclick="return getnt(this)">VIEW</a></p>

answered Jun 1, 2011 at 2:12

Phil

166k25 gold badges265 silver badges269 bronze badges

Collectives™ on Stack Overflow

Javascript Function Accepting PHP Variables

3 Answers 3

1 Comment

3 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related