iterating through an array using loops and if else statements

Question

I'm trying to compare the name to the item names in the list and return the price of that item but it's not going through the full list. Can someone explain to me what I'm doing wrong and how to correct it?

let items = [
  {
    itemName: "Effective Programming Habits",
    type: "book",
    price: 13.99
  },
  {
    itemName: "Creation 3005",
    type: "computer",
    price: 299.99
  },
  {
    itemName: "Finding Your Center",
    type: "book",
    price: 15.00
  }

]function priceLookup (itemsList, name) {
  let price = null;
  for (item of itemsList) {
    if (item.itemName === name) {
      price = item.price;
    }
    else { price = "No item found with that name";
    }
  }
  return price;
}

Please provide a minimal reproducible example, which should include a sample of data that is in itemsList and a value for name, so that we can recreate the issue. You can use Stack Snippets (icon looks like <>) to provide that. — Heretic Monkey
– Heretic Monkey, Commented Jun 15, 2020 at 19:49
Instead of initially setting price = null, set this to the not found text, and use break as pointed out — Keith
– Keith, Commented Jun 15, 2020 at 19:51
Does this answer your question? Find object by id in an array of JavaScript objects — Heretic Monkey
– Heretic Monkey, Commented Jun 15, 2020 at 19:52

Jacob · Accepted Answer · 2020-06-15 19:49:48Z

2

It is going through the full list, and that's the problem. Notice that if the if branch is hit, price gets populated, but the next time around in the loop, the else branch may take place, so price will be overwritten with that string.

You can use break to stop looping in your if branch once you've found the match, or use the find method of the Array instead.

function priceLookup (itemsList, name) {
  const price = itemsList.find(item => item.itemName === name);
  return price ?? "No item found with that name";
}

answered Jun 15, 2020 at 19:49

Jacob

79k24 gold badges159 silver badges245 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Shivanshu Gupta · Accepted Answer · 2020-06-15 19:54:40Z

1

It's happening because you have reassigned price in else to ""No item found with that name". Possible Solution:

function priceLookup (itemsList, name) {
  let price = "No item found with that name";
  for (item of itemsList) {
    if (item.itemName === name) {
      price = item.price;
      break;
    }
  }
  return price;
}

edited Jun 15, 2020 at 19:54

answered Jun 15, 2020 at 19:51

Shivanshu Gupta

3242 silver badges9 bronze badges

Collectives™ on Stack Overflow

iterating through an array using loops and if else statements

2 Answers 2

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related