How to Add the Results of a Function to an Array in Powershell

Question

So im pretty new to powershell and i have multiple questions on how to write scripts using it but right now my main issue is that i want to be able to ping all of the computers on my network and take the names of the computers that ping back and put them into an array so that i can push updates to the computers that are on the network just using one array containing the current computers on the network. here is what i am working with right now.

foreach ($c in $204computernames) 
{if(test-connection -computername $c.name  -count 1 -quiet)
{write-host $c.name
}
}

currently this string of code runs a foreach loop so that $c(the computers) run against $204computernames(the known computers on the network)then it tests the positive connections through the if statement and finally at the end it outputs the names of the computers that are on the network. Now the problem im understanding from this is when i use a foreach loop that it will run against all of the known computers and as each computer is put through the loop it is replaced by the preceding one, but i want each and every one that comes back on the network to be stored in an array. Is there a way that i can do this with the current format or is there a certain way that i can tweak what i have so that i can get the output i want?

Is $computernames.name (as an argument to Test-Connection) a typo? — Mathias R. Jessen
– Mathias R. Jessen, Commented Jun 16, 2020 at 14:59
it was a typo, i corrected the code, iv been working with alot of variations to get it to work the way i want it to — Zizzay
– Zizzay, Commented Jun 16, 2020 at 15:15

Mathias R. Jessen · Accepted Answer · 2020-06-16 15:16:36Z

1

The idiomatic solution to "how do I filter a list against a condition and save the results" would be to pipe the input to Where-Object:

$onlineComputers = $204computernames |Where-Object { Test-Connection $_.name -Count 1 -Quiet }

answered Jun 16, 2020 at 15:16

Mathias R. Jessen

178k13 gold badges175 silver badges234 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Zizzay Over a year ago

thank you so much for this answer, it worked exactly how i wanted it to!

Mathias R. Jessen Over a year ago

@Zizzay That's great to hear, you're most welcome! Please consider marking the answer "accepted" by clicking the checkmark on the left :)

Collectives™ on Stack Overflow

How to Add the Results of a Function to an Array in Powershell

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related