curl command works manually but not in script

Question

I have a curl command in a script, when the script is run the command isn't able to fetch a resource (the command itself works, it's the response that's incorrect), but if I copy and paste the same command into the terminal I get the expected response.

After reading this my script looks like this:

jsess=`awk '/\sJSESSION/ { print "\x27"$6"="$7"\x27" }' cookies.txt`
ARGS=( -k -v -b $jsess $url7)
echo "curl ${ARGS[*]}"
curl "${ARGS[@]}"

and the last echo looks like this:

curl -k -v -b 'JSESSIONID=hexystuff' https://secretstuff.com

The last curl doesn't work, but copy-pasting that echo works. Any ideas what could be wrong? Thanks.

Useless use of an array; a string is sufficient and not error prone and the backquote is used in the old-style command substitution, e.g. <pre>foo=command</pre> The foo=$(command) syntax is recommended instead. Backslash handling inside $() is less surprising, and $() is easier to nest. Check mywiki.wooledge.org/BashFAQ/082 — Gilles Quénot
– Gilles Quénot, Commented Jun 21, 2020 at 19:47
@eyevan Neat, thanks. Seems like the cmd got some extra apostrophes somehow. Turned out none were needed anyway, great. — Erik Vesterlund
– Erik Vesterlund, Commented Jun 21, 2020 at 20:04

Philippe · Accepted Answer · 2020-06-21 20:05:21Z

1

The problem seems in the two single quotes, try this :

jsess="$(awk '/\sJSESSION/ { print $6"="$7 }' cookies.txt)"
ARGS=( -k -v -b "$jsess" "$url7")
echo "curl ${ARGS[*]}"
curl "${ARGS[@]}"

answered Jun 21, 2020 at 20:05

Philippe

27.7k4 gold badges28 silver badges45 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

petrus4 · Accepted Answer · 2020-06-23 18:16:58Z

0

args="-k -v -b"
jsess=$(awk '/\sJSESSION/ { print "\x27"$6"="$7"\x27" }' cookies.txt)
url7="https://secretstuff.com"

curl "${args}" "${jsess}" "${url7}"

The use of arrays is not my personal preference, and I believe the current situation demonstrates why. I believe that as much as possible, every individual item of data should be contained in its' own variable. This makes accessing said variables much simpler, and also greatly increases flexibility. I can choose exactly which pieces of information will go into a given command line.

edited Jun 23, 2020 at 18:16

answered Jun 22, 2020 at 18:58

petrus4

6144 silver badges7 bronze badges

3 Comments

ysf Over a year ago

While this code may resolve the OP's issue, it is best to include an explanation as to how your code addresses the OP's issue. In this way, future visitors can learn from your post, and apply it to their own code. SO is not a coding service, but a resource for knowledge. Also, high quality, complete answers are more likely to be upvoted. These features, along with the requirement that all posts are self-contained, are some of the strengths of SO as a platform, that differentiates it from forums. You can edit to add additional info &/or to supplement your explanations with source documentation.

bad_coder Over a year ago

One reason not to post "code only" answers is because they fall into a category that can be flagged as VLQ and are liable to be put on a review queue for deletion, please consider this answer that explains it better. The other answer in this thread is mostly exempt of that, because it does include a brief explanation.

petrus4 Over a year ago

I have edited this and offered an explanation; that I greatly prefer seperate variables to arrays, for reasons of greater clarity and flexibility.

Collectives™ on Stack Overflow

curl command works manually but not in script

2 Answers 2

Comments

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related