ASP.NET MVC2 +file uploading (HttpPostedFileBase class)

Question

I have problem with uploading my file. I want to upload it from my edit view:

    <% 
    using (Html.BeginForm("edit","profile",FormMethod.Post, new { enctype="multipart/form-data" }))
    {%>
    <%: Html.ValidationSummary(true) %>

    <%: ViewData["ErrorMessage"] %>
    <fieldset>
        <legend>Fields</legend>

        <div class="editor-label">
            <%: Html.LabelFor(model => model.Image) %>
        </div>
        <div class="editor-field">
            <input type="file" id="Image" name="Image" />
            <label id="LabelErrorImage" class="errorMessage" />
        </div> 

        <p>
            <input type="submit" value="Save" onclick="return Validate(); return false;"/>
        </p>
    </fieldset>

<% } %>

I want to use HttpPostedFileBase class. My edit action:

[Authorize]
        [HttpPost]
        [AcceptVerbs(HttpVerbs.Post)]
        public ActionResult Edit(string id, HttpPostedFileBase file, FormCollection formValues)
        {
                    if (ModelState.IsValid)
                    {

                        if (file != null && file.ContentLength > 0)
                        {
                            CustomHelpers.createFolder();
                            var tmpPath = MyConfig.UPLOAD_FILE_PATH + "/" + Membership.GetUser().ProviderUserKey.ToString();
                            var path = Path.Combine(Server.MapPath(MyConfig.UPLOAD_FILE_PATH), "Avatar");
                            var fileExtension = Path.GetExtension(file.FileName);
                            file.SaveAs(path);
                            user.Image = "Avatar";
                        }
                        adventureDB.SaveChanges();

                        return RedirectToAction("Index");
                    }
        }

But I always have empty the file object, why????? Do you have any ideas, suggestions why it can work like that? Maybe there is problem how I pass on the file value to my Edit action?

EDIT: IT IS REALLY STRANGE AS EVEN WHEN I REMOVE
using (Html.BeginForm("Index","Profile",FormMethod.Get, new { enctype="multipart/form-data" }))

The page source still has:

<body>

    <form method="post" action="6111e591-b92d-4bcb-b214-ab8f664b35f9" id="form1">

I mean I can not change the tag but have no idea why :/

Rippo · Accepted Answer · 2011-06-08 17:29:22Z

1

Try changing:-

public ActionResult Edit(string id, HttpPostedFileBase file, 
  FormCollection formValues)

to:-

public ActionResult Edit(string id, HttpPostedFileBase image, 
  FormCollection formValues)

as the name of your input is image

 <input type="file" id="Image" name="Image" />

edit To be honest something else is stopping the binding of image. Is this the whole form that you have posted?

A few things to test

You have HTTPOST decorating your method twice, although I don't believe this should make a difference.
View the source and make sure there is nothing else named name=image in the source.
Make sure you empty your cache and make sure source is correct before testing again
Try using <form action="/profile/index" method="post" enctype="multipart/form-data">
Judging by your last edit you have a problem with master pages/layout? Is this a mvc/webforms hybrid?

edited Jun 8, 2011 at 17:29

answered Jun 8, 2011 at 16:37

Rippo

22.5k14 gold badges83 silver badges118 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

canimbenim Over a year ago

Yes true, I have changed it but it still has null :/

canimbenim Over a year ago

No it is not all code as it is very long but I noticed that it does not matter what I write in my view as always it is redirecting to the same function. Maybe because I use Master site and it uses a mechanism which I do not know?

canimbenim Over a year ago

Further more I have 2 forms in the source code: <form method="post" action="6111e591-b92d-4bcb-b214-ab8f664b35f9" id="form1"> <div class="aspNetHidden"> <input type="hidden" name="__VIEWSTATE" id="__VIEWSTATE" value="/wEPDwUJMjIyODQ4MTE2ZGQ0zXwQxrpoQd+by+EOC4qY3mQAo7zW2FgvbThGQUWMVQ==" /></div> and then the second which I wrote in view: <form action="/Profile/Edit" enctype="multipart/form-data" method="POST">

canimbenim Over a year ago

Yes I have found the mistake!!!! In Master.Site it default creates form and there can not be nested forms as the second one is ignored! I have lost so many time to found it out! Thanks for help!

Rippo Over a year ago

No worries, perhaps you could mark this question as answered, thanks

canimbenim · Accepted Answer · 2011-06-09 09:23:37Z

1

The solution of this problem when:

We use Master.Site,
We want to upload file in a view,
We are sure that it should work but we all the time has null,

Then:

Guys were right - I had wrong name in my view - check it!
Check source code of your view and if you have 2 < form > tags you should remove the < form > tag from Master site as then the second one is ignored!

Now it should work.

answered Jun 9, 2011 at 9:23

canimbenim

6494 gold badges10 silver badges24 bronze badges

Comments

Malevolence · Accepted Answer · 2011-06-08 16:37:46Z

0

Well, in your view you named the file input 'image' but your action method accepts a parameter called 'file'. Rename one of those and it should work.

answered Jun 8, 2011 at 16:37

Malevolence

1,85712 silver badges9 bronze badges

1 Comment

canimbenim Over a year ago

Yes, but I have changed it now and still the same :/

Collectives™ on Stack Overflow

ASP.NET MVC2 +file uploading (HttpPostedFileBase class)

3 Answers 3

5 Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

5 Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related