how to string.join object array parameters with customize output

Question

I have an object like that

    public class MyModel
    {
        public int Key { get; set; }
        public string Value { get; set; } 
    }

And I have model like List<MyModel>

    model[0]=new MyModel(){Key = 1,Value ="Something"};
    model[1]=new MyModel(){Key = 3,Value ="Something else"};

I want this output :

    1. Value is = Something //there is \n here
    3. Value is = Something else

So the seperator is \n and while string.join(" \n ", ? ) what should I do?

Is that possible or not? I did it like that but I want to learn can I string.join() do that:

    var newArray = model.Select(x => ((x.Key)+". Value is ="+x.Value));
    string.join(" \n ",newArray );

Sorry for my bad english...

The method is called string.Join() not string.join(). And you should remove the space before "\n" in the separator. But other than that, your code seems to deliver your desired result. — derpirscher
– derpirscher, Commented Jan 28, 2021 at 8:19
newArray is poorly named: the result of Select is an IEnumerable, not an array — Caius Jard
– Caius Jard, Commented Jan 28, 2021 at 8:21
@Backs yes my solution is works fine but I wondering is the string.join can do that without pre custimization or linq — BMErEr
– BMErEr, Commented Jan 28, 2021 at 8:46

Vladislav · Accepted Answer · 2021-01-28 08:31:22Z

1

var modelList = new List<MyModel>(){
        new MyModel(){ Key = 1, Value = "Value 1"},
        new MyModel(){ Key = 3, Value = "Value 2 with Key3"}
    };
    
    var stringArray = modelList.Select(model=> $"{model.Key}. Value={model.Value}");
    var finalString = String.Join('\n', stringArray);
    Console.Write(finalString);

https://dotnetfiddle.net/buCe8P

answered Jan 28, 2021 at 8:31

Vladislav

2181 silver badge14 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

BMErEr Over a year ago

Isn't it same as my solution ? just different syntax in select

Vladislav Over a year ago

@BMErEr so yes. I just answered, because you asked. I have 10+ years of exp in C# and we often use String.Join() method. So "I want to learn can I string.join() do that" yes, you can, and it is the right way! The better solution would be String.Join(Environment.NewLine, stringArray); and much more better is using of StringBuilder.

dovid · Accepted Answer · 2021-01-28 10:05:12Z

0

You did well. There are other ways but they are no more correct (in some cases at least).

Example with custom ToString method:

var all = string.Join("\n", model);

public class MyModel
{
    public int Key { get; set; }
    public string Value { get; set; }

    public override string ToString() => $"{Key}. Value Is: {Value}";
}

Or directly with project array:

var all = string.Concat(model.Select(x => $"{x.Key}. Value Is: {x.Value}\n"));

but there's an unnecessary line brake at the end.

edited Jan 28, 2021 at 10:05

answered Jan 28, 2021 at 8:18

dovid

6,5114 gold badges35 silver badges82 bronze badges

2 Comments

Caius Jard Over a year ago

Remove the \n from the ToString and do it via string.Join

derpirscher Over a year ago

adding the linebreak directly in the ToString() is a bad idea because, this way the consumer can't decide whether to have a linebreak or not. Why not using string.Join() and use linebreak as separator?

Collectives™ on Stack Overflow

how to string.join object array parameters with customize output

2 Answers 2

2 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related