implement try catch in database class php

Question

this here below is my class database in php

<?php
class DB
{

    private $SQLcommand;
    private $bd;

    public function setSQLcommand($valor)
    {
        $this->SQLcommand = $valor;
    }
    public function getSQLcommand()
    {
        return($this->SQLcommand);
    }

    function __construct()
    {
        $this->bd = new PDO("mysql:host=localhost;dbname=cpd", "root", "");

    }
    public function ExecSQL()
    {
        if ($this->SQLcommand != "")
            return($this->bd->exec($this->SQLcommand));
        else
            return(false);
    }   
    public function ExecSelect()
    {
        if ($this->SQLcommand != "")
        {
            $data = $this->bd->query($this->SQLcommand);
            return($data->fetchAll());


        }
        else
            return(false);
    }
    function __destruct()
    {
        $this->bd = null;
    }

}
?>

and here is how I instantiate

include_once 'db_class.php';

$e = new DB();
$e->setSQLcommand("INSERT INTO characteristic (id_charac,name_charac)
                VALUES ('','".$_POST["nomecharac"]."')");
$e->ExecSQL();


$p = new DB();
$p->setSQLcommand("select * from characteristic");                  
$data = $p->ExecSelect();

I would ask where in the code I can I put a try catch, that if an error occurs the try catch redirects to the file maintenance.php, and prevent the bank's User and password are showed...thank you all...

Ahmad · Accepted Answer · 2011-08-19 14:41:35Z

2

You can put in your constructor __construct()

try {
    $this->bd = new PDO("mysql:host=localhost;dbname=cpd", "root", "");
} catch (PDOException $e) {
    die('Database connection could not be established.');
}

answered Aug 19, 2011 at 14:41

Ahmad

4,2349 gold badges33 silver badges41 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Chris Forrence · Accepted Answer · 2011-08-19 14:36:21Z

2

First thing is that I'd use prepared statements; someone can put what they want into $_POST["nomecharac"] that can let them run a command that they want.

As for where to put the try-catch, if you want there to always be a redirect to maintenance.php, put it in the class. Otherwise, put it in the instantiation.

Cheers!

answered Aug 19, 2011 at 14:36

Chris Forrence

10.2k11 gold badges50 silver badges66 bronze badges

2 Comments

Marc Towler Over a year ago

Good answer, especially with the prepared statements +1

Rangel Cortez Over a year ago

could you illustrate for me ? i'll be very grateful if you did

Wesley van Opdorp · Accepted Answer · 2011-08-19 14:42:06Z

1

Your Database class should not know that your application has to redirect to a specific page, only that an exception has occurred.

Let Database class throw exceptions.
Catch the exception in your application, and take action.

answered Aug 19, 2011 at 14:42

Wesley van Opdorp

15k4 gold badges43 silver badges59 bronze badges

1 Comment

Rangel Cortez Over a year ago

could you illustrate for me ? i'll be very grateful if you did

Collectives™ on Stack Overflow

implement try catch in database class php

3 Answers 3

Comments

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related