Bash array loop only takes the first entry

Question

Good evening,

i just try to stop some docker containers defined in an array. But only the first one is stopped but four times.

CONTAINERTOSTOP=(webgrabplus Nextcloud ddclient MariaDB-10.6)

for constopping in "${CONTAINERTOSTOP[@]}"; do                      
docker container stop $CONTAINERTOSTOP done

My script only stops the webgrabplus container but for four times so i think the loop works.

Where is my fault here ?

DevSolar · Accepted Answer · 2022-06-24 15:29:25Z

4

You are stopping $CONTAINERTOSTOP. You want $constopping.

You are also either missing a ; or a newline after the docker command.

for constopping in "${CONTAINERTOSTOP[@]}"
do
    docker container stop "$constopping"
done

(Of course, @ufopilot's answer is even better in the specific case, but I let my answer stand for the "if you want a loop..." case.)

answered May 17, 2022 at 19:19

DevSolar

71k22 gold badges141 silver badges217 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

and since $CONTAINERTOSTOP == ${CONTAINERTOSTOP[0]} == webgrabplus the stop is issued against webgrabplus 4 times

Better to quote "$constopping"

ufopilot · Accepted Answer · 2022-06-24 14:24:02Z

2

To stop just using (without loop):

CONTAINERTOSTOP=(webgrabplus Nextcloud ddclient MariaDB-10.6)
docker stop "${CONTAINERTOSTOP[@]}"

answered May 17, 2022 at 19:46

ufopilot

3,9852 gold badges13 silver badges14 bronze badges

Thank you, sometimes you cant find the forest for the trees.