C++ filling in array with input from another

Question

I'm just taking input for two arrays and manipulating the information. When I take input for both arrays it puts the information from the second into both arrays. In the code below I haven even commented out the input for the second array to see what happens and it still puts the input for M into both arrays. Can anyone see the cause?

int M[0], N[0];

std::cin >> m >> n;

  
  for (int i = 0; i < m; ++i)
    {
      std::cin >> M[i];
    }

 for(int i=0; i<m; i++)
    {
      std::cout << M[i];
    }
  
  std::cout << "\n";
  
  for(int i=0; i<n; i++)
    {
      std::cout << N[i];
    }

Vlad from Moscow · Accepted Answer · 2022-09-11 18:22:34Z

1

For starters these declarations

int M[0], N[0];

are invalid, You may not declare an array with zero elements.

Thus the code has undefined behavior.

Secondly variable length arrays are not a standard C++ feature. Either declare the arrays with the potentially maximum number of elements or use the standard container std::vector.

edited Sep 11, 2022 at 18:22

answered Sep 11, 2022 at 18:17

Vlad from Moscow

313k27 gold badges204 silver badges358 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Skerdi Velo · Accepted Answer · 2022-09-11 18:13:01Z

0

the code that you just showed has a problem. You print only M because you didn't do the input for-loop for the N array. So the array N has nothing inside. So to fix this do another for and ask for input in the array N.

for (int i = 0; i < m; ++i)
{
  std::cin >> N[i];
}

Hope this helps.

answered Sep 11, 2022 at 18:13

Skerdi Velo

4134 silver badges18 bronze badges

Collectives™ on Stack Overflow

C++ filling in array with input from another

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related