help to optimize a function in php

Question

i have created a function in php to convert an string like:

[20110911, 20110913, [20110915, 20110918], 20110920, 20110922, 20110924, [20110926, 20110927], 20110929]

to php array like:

Array
(
    [0] => 20110911
    [1] => 20110913
    [2] => Array
        (
            [0] => 20110915
            [1] => 20110918
        )

    [3] => 20110920
    [4] => 20110922
    [5] => 20110924
    [6] => Array
        (
            [0] => 20110926
            [1] => 20110927
        )

    [7] => 20110929
    [8] => Array
        (
            [0] => 20111001
            [1] => 20111002
        )

    [9] => 20111004
    [10] => Array
        (
            [0] => 20111006
            [1] => 20111007
        )

)

The function is:

function dates2Array($d){
    if($d!==''){
        $d=substr($d, 1, strlen($d)-2);
        $d=explode(', ', $d);
        $dates=array();
        if(!empty($d)){
            $j=1;
            foreach($d as $k=>$v){
                if(substr($v, 0, 1)==='[') $dates[]=array(substr($v, 1, strlen($v)));
                elseif(substr($v, strlen($v)-1, strlen($v))===']'){
                    $dates[$k-$j][1]=substr($v, 0, strlen($v)-1);
                    $j++;
                }
                else $dates[]=$v;
            }
        }
    }

    return $d!==''?$dates:'';
}

I am not fully happy with my function. I think it can be more optimized and compressed for speed.. Can it be?

genesis · Accepted Answer · 2011-09-11 16:27:37Z

8

Use JSON (json_decode() and json_encode()) instead

http://sandbox.phpcode.eu/g/b3814/2

result:

Array
(
    [0] => 20110911
    [1] => 20110913
    [2] => Array
        (
            [0] => 20110915
            [1] => 20110918
        )

    [3] => 20110920
    [4] => 20110922
    [5] => 20110924
    [6] => Array
        (
            [0] => 20110926
            [1] => 20110927
        )

    [7] => 20110929
)

answered Sep 11, 2011 at 16:27

genesis

51.1k20 gold badges99 silver badges127 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

Vaibhav Gupta Over a year ago

will it convert like the same array as mentioned above? I do but its doing nothing... :(

genesis Over a year ago

@Vaib take a look at my demo. Be sure you have PHP with PECL json >= 1.2.0

genesis Over a year ago

@VaibhavGupta: it is. try again

markus Over a year ago

@Vaibhav Gupta: The link works, it's something in your system that doesn't!

genesis Over a year ago

@VaibhavGupta: Do you think you could share your IP here?

|

Lorenz Lo Sauer · Accepted Answer · 2011-09-11 16:39:42Z

2

You can pass your string in {...} and pass it to json_decode(str, true) to get back an array.

>> json_decode("[20110911, 20110913, [20110915, 20110918], 20110920, 20110922, 2
0110924, [20110926, 20110927], 20110929]")
array (
  0 => 20110911,
  1 => 20110913,
  2 =>
  array (
    0 => 20110915,
    1 => 20110918,
  ),
  3 => 20110920,
  4 => 20110922,
  5 => 20110924,
  6 =>
  array (
    0 => 20110926,
    1 => 20110927,
  ),
  7 => 20110929,
)

answered Sep 11, 2011 at 16:39

Lorenz Lo Sauer

25k16 gold badges89 silver badges87 bronze badges

1 Comment

genesis Over a year ago

it is exactly the answer I posted 13 minutes ago

Collectives™ on Stack Overflow

help to optimize a function in php

2 Answers 2

6 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

6 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related