Access custom attributes via jquery

Question

I need to access to the custom attribute or data of my link but I can't. My code is simple yet in repeater. I don't know if this is causing a problem. Here is the code:

 <a class="showAllComm" data-userid='<%# DataBinder.Eval(Container.DataItem, "USER_ID")%>' href="#sa">Show all comments</a>

Here is my click event:

$('.showAllComm').click(function(index, element) {
            var commId = $(element).data("userid");
 })

commId is undefined but I can see it in the source code that it has value of 1.

how can I access to the userId?

Thank you

user113716 · Accepted Answer · 2011-09-14 22:29:37Z

8

Reference the element with this instead of the second parameter:

var commId = $(this).data("userid");

The arguments passed to an event handler are not the index and element as you'd have in .each().

By default, you just get a single event argument passed.

DEMO: http://jsfiddle.net/Jjbwd/

$('.showAllComm').click(function( event ) {

    alert( event.type ) // click

    var commId = $(this).data("userid");
});

answered Sep 14, 2011 at 22:29

user113716

323k64 gold badges454 silver badges441 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

Pabuc Over a year ago

thank you but I wonder.. what is the reason for not being able to access with element?

Alnitak Over a year ago

@Pabuc because there is no second parameter to the callback, the only parameter is a jQuery event object.

Nick Craver Over a year ago

In these cases there's no need to create the jQuery object, a simpler $.data(this, "userid") would be more efficient...as it just does a this[$.expando] call, rather than a full jQuery() call/init.

user113716 Over a year ago

@Pabuc: Because jQuery doesn't pass a second argument by default.

user113716 Over a year ago

@Nick: Are you sure that works to initially access data- attributes that are not yet in jQuery.cache? It doesn't seem that way in this example.

|

RSG · Accepted Answer · 2011-09-14 22:31:40Z

1

The data method is not a shortcut for the attr method. It takes an element and an attribute, per the docs

Just use attr("data-userid")

answered Sep 14, 2011 at 22:31

RSG

7,1436 gold badges39 silver badges51 bronze badges

1 Comment

RSG Over a year ago

Well I'll be. Maybe if I'd been using this all along I wouldn't have gotten lazy about using a data prefix on all my data attributes.

Collectives™ on Stack Overflow

Access custom attributes via jquery

2 Answers 2

6 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

6 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related