php return mysql_query

Question

How is it possible to retrieve the mysql_query from a function? For instance:

class A() {
   ...
   function getAll($l=1) {
      ...
      $result = mysql_query($query); 
      return $result
   }
   ...
}

$a = new A();
$r = $a -> getAll(2);
while ($row = mysql_fetch_assoc($r)) {
   // do something
}

This code above does not work when I return $result from the function. However, when I use the mysql_fetch_assoc function in getAll function, it works perfectly. So basically, my question is how to return a mysql result set from a function?

** EDIT **

I actually get no errors. The while statement used liked above will just not execute. But the query works perfectly when I execute it from within the getAll function.

What doesn't work? Do you get some kind of error? No rows returned? — regality
– regality, Commented Sep 20, 2011 at 21:49
Do you get an error? Do you need a ; after return $result; ? — labue
– labue, Commented Sep 20, 2011 at 21:50
Change your mysql_query line to this and see if it is just erroring out: $result = mysql_query($query) or trigger_error(mysql_error()); — Jim
– Jim, Commented Sep 20, 2011 at 21:52
Have you tried to print out $result before returnig and $r after function call? (by print_r() function) — Ernest Staszuk
– Ernest Staszuk, Commented Sep 20, 2011 at 21:52
You're not checking if mysql_query was successful. If $result is FALSE, then you should read mysql_error(). — Ondřej Mirtes
– Ondřej Mirtes, Commented Sep 20, 2011 at 21:52

Matteo Riva · Accepted Answer · 2011-09-20 21:51:34Z

3

Don't return the result resource from the query, but rather return the data extracted from that resource:

$data = array();

while ( $row = mysql_fetch_assoc($result) ) {
    $data[] = $row;
}

return $data;

answered Sep 20, 2011 at 21:51

Matteo Riva

25.1k13 gold badges75 silver badges105 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

webbiedave · Accepted Answer · 2011-09-20 22:03:33Z

1

Absolutely it works.

Do a var_dump($r) to make sure you're getting a resource. If not, double-check your SQL. There may be an error in it.

Also turn on other error reporting at the top of your script (as well as checking mysql_error) for better clues as to what's wrong:

ini_set('display_errors', true);
error_reporting(E_ALL);

You've edited much of your code so it's difficult to investigate further. Just make sure that your method is not closing the mysql connection.

edited Sep 20, 2011 at 22:03

answered Sep 20, 2011 at 21:58

webbiedave

49k8 gold badges92 silver badges104 bronze badges

Collectives™ on Stack Overflow

php return mysql_query

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related