AWS lambda function not giving correct output

Question

I am new to python using boto3 for AWS. I am creating a lambda function that will return orphaned snapshots list. Code is -

def lambda_handler(event, context):
    ec2_resource = boto3.resource('ec2')
    
    # Make a list of existing volumes
    all_volumes = ec2_resource.volumes.all()
    volumes = [volume.volume_id for volume in all_volumes]
    
    # Find snapshots without existing volume
    snapshots = ec2_resource.snapshots.filter(OwnerIds=['self'])
    
    # Create list of all snapshots
    osl =[]
    
    for snapshot in snapshots:
        if snapshot.volume_id not in volumes:
            osl.append(snapshot)
            print('\n Snapshot ID is :-    '+str(snapshot))
            #snapshot.delete()
            continue
        for tag in snapshot.tags:
          if tag['Key'] == 'Name':
              value=tag['Value']
              print('\n Snapshot Tags are:- '+str(tag))
              break
    print('Total orphaned snapshots are:-    '+str(len(osl)))

This returns list of snapshots & tags too in incorrect format.

Surprisingly, when I run same code in another account, it gives lambda function error -

I have created same permissions IAM role. But different results in different accounts is something i am not gettting.

Mehmet Güngören · Accepted Answer · 2023-01-22 11:58:27Z

1

You are printing snapshot object but you want to print id. Second problem is all snapshot do not need to have tags, you need to check if snapshot have tags or not.

def lambda_handler(event, context):
    ec2_resource = boto3.resource('ec2')
    
    # Make a list of existing volumes
    all_volumes = ec2_resource.volumes.all()
    volumes = [volume.volume_id for volume in all_volumes]
    
    # Find snapshots without existing volume
    snapshots = ec2_resource.snapshots.filter(OwnerIds=['self'])
    
    # Create list of all snapshots
    osl =[]
    
    for snapshot in snapshots:
        if snapshot.volume_id not in volumes:
            osl.append(snapshot.id)
            print('\n Snapshot ID is :-    ' + snapshot.id)
    for snapshot in snapshots:
        if snapshot.volume_id not in volumes:
            osl.append(snapshot.id)
            print('\n Snapshot ID is :-    ' + snapshot.id)
            if snapshot.tags:
                for tag in snapshot.tags:
                    if tag['Key'] == 'Name':
                        value = tag['Value']
                        print('\n Snapshot Tags are '+ tag['Key'] + ", value = " + value)
                        break
    print('Total orphaned snapshots are:-    '+str(len(osl)))

edited Jan 22, 2023 at 11:58

answered Jan 22, 2023 at 11:31

Mehmet Güngören

2,8342 gold badges13 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Cloud Wanderer Over a year ago

Thanks! I believe that id thing is what I missed. Also for -- Second problem is all snapshot do not need to have tags, you need to check if snapshot have tags or not -> added else to print no tags. Next step to check how to print tags below the ID itself

Mehmet Güngören Over a year ago

You need to move tags condition under volume check, check my answer with updated version.

Collectives™ on Stack Overflow

AWS lambda function not giving correct output

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related